Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Sources: aws_outposts_site(s) #13825

Merged
merged 2 commits into from Jun 18, 2020
Merged

New Data Sources: aws_outposts_site(s) #13825

merged 2 commits into from Jun 18, 2020

Conversation

bflad
Copy link
Member

@bflad bflad commented Jun 18, 2020 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* **New Data Source:** `aws_outposts_site`
* **New Data Source:** `aws_outposts_sites`

Output from acceptance testing:

--- PASS: TestAccAWSOutpostsSitesDataSource_basic (19.61s)
--- PASS: TestAccAWSOutpostsSiteDataSource_Id (22.84s)
--- PASS: TestAccAWSOutpostsSiteDataSource_Name (27.11s)

@bflad
New Data Sources: aws_outposts_site(s)
9b61e42 
Output from acceptance testing:

```
Pending access

    TestAccAWSOutpostsSiteDataSource_Id: data_source_aws_outposts_sites_test.go:62: skipping since no Sites Outpost found
--- SKIP: TestAccAWSOutpostsSiteDataSource_Id (3.14s)
    TestAccAWSOutpostsSitesDataSource_basic: data_source_aws_outposts_sites_test.go:62: skipping since no Sites Outpost found
--- SKIP: TestAccAWSOutpostsSitesDataSource_basic (6.16s)
    TestAccAWSOutpostsSiteDataSource_Name: data_source_aws_outposts_sites_test.go:62: skipping since no Sites Outpost found
--- SKIP: TestAccAWSOutpostsSiteDataSource_Name (6.93s)
```
@bflad bflad requested a review from a team June 18, 2020 14:46
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/outposts Issues and PRs that pertain to the outposts service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jun 18, 2020
@gdavison gdavison self-assigned this Jun 18, 2020
@bflad
Copy link
Member Author

bflad commented Jun 18, 2020

Received access to an account with this information available and verified. 😄

--- PASS: TestAccAWSOutpostsSitesDataSource_basic (19.61s)
--- PASS: TestAccAWSOutpostsSiteDataSource_Id (22.84s)
--- PASS: TestAccAWSOutpostsSiteDataSource_Name (27.11s)

@bflad bflad added the new-data-source Introduces a new data source. label Jun 18, 2020
gdavison
gdavison approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments, otherwise LGTM 🚀

--- SKIP: TestAccAWSOutpostsSitesDataSource_basic (1.28s)
--- SKIP: TestAccAWSOutpostsSiteDataSource_Name (1.38s)
--- SKIP: TestAccAWSOutpostsSiteDataSource_Id (5.33s)

website/docs/d/outposts_sites.html.markdown Outdated

## Attribute Reference

In addition to all arguments above, the following attributes are exported:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no "arguments above" :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmmmm copypasta 🍝 will update!

aws/data_source_aws_outposts_site.go Outdated
Comment on lines 24 to 33
"id": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},
"name": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should one of these be required, using AtLeastOneOf or ExactlyOneOf?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, we should likely encourage good implementations for folks even with just one site to start. 👍

@bflad bflad added this to the v2.67.0 milestone Jun 18, 2020
@bflad
service/outposts: Review feedback
30da901 
Output from acceptance testing:

```
--- PASS: TestAccAWSOutpostsSiteDataSource_Id (24.36s)
--- PASS: TestAccAWSOutpostsSiteDataSource_Name (27.23s)
```
@bflad
Copy link
Member Author

bflad commented Jun 18, 2020

Updated to address review feedback and still passes acceptance testing:

--- PASS: TestAccAWSOutpostsSiteDataSource_Id (24.36s)
--- PASS: TestAccAWSOutpostsSiteDataSource_Name (27.23s)

@bflad bflad merged commit 3a6e539 into master Jun 18, 2020
@bflad bflad deleted the f-aws_outposts_site branch June 18, 2020 19:54
bflad added a commit that referenced this pull request Jun 18, 2020
@bflad
Update CHANGELOG for #13825
aefa18c
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/outposts Issues and PRs that pertain to the outposts service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.67.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bflad @gdavison