Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rd/ebs_snapshot resources - add arn attribute #13840

Merged
merged 4 commits into from Jun 22, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 19, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624, #13527, #13820

Release note for CHANGELOG:

resource_aws_ebs_snapshot - add arn attribute
data_source_aws_ebs_snapshot - add arn attribute
resource_aws_ebs_snapshot_copy - add arn attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEbsSnapshotDataSource_|TestAccAWSEbsSnapshotCopy_|TestAccAWSEBSSnapshot_'
--- PASS: TestAccAWSEBSSnapshot_basic (59.84s)
--- PASS: TestAccAWSEBSSnapshot_tags (111.47s)
--- PASS: TestAccAWSEBSSnapshot_withDescription (57.59s)
--- PASS: TestAccAWSEBSSnapshot_withKms (73.15s)
--- PASS: TestAccAWSEBSSnapshot_disappears (56.56s)

--- PASS: TestAccAWSEbsSnapshotCopy_basic (88.12s)
--- PASS: TestAccAWSEbsSnapshotCopy_tags (148.15s)
--- PASS: TestAccAWSEbsSnapshotCopy_withDescription (92.78s)
--- PASS: TestAccAWSEbsSnapshotCopy_withRegions (82.04s)
--- PASS: TestAccAWSEbsSnapshotCopy_withKms (82.25s)
--- PASS: TestAccAWSEbsSnapshotCopy_disappears (86.79s)

--- PASS: TestAccAWSEbsSnapshotDataSource_basic (80.13s)
--- PASS: TestAccAWSEbsSnapshotDataSource_Filter (68.19s)
--- PASS: TestAccAWSEbsSnapshotDataSource_MostRecent (88.71s)

@DrFaust92 DrFaust92 requested a review from a team June 19, 2020 14:39
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 19, 2020
@DrFaust92 DrFaust92 changed the title rd/ebs_snapshot resource - add arn attribute rd/ebs_snapshot resources - add arn attribute Jun 19, 2020
@bflad bflad added this to the v2.68.0 milestone Jun 22, 2020
@bflad bflad self-assigned this Jun 22, 2020
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 22, 2020
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jun 22, 2020
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEBSSnapshot_basic (37.67s)
--- PASS: TestAccAWSEBSSnapshot_disappears (37.54s)
--- PASS: TestAccAWSEBSSnapshot_tags (48.54s)
--- PASS: TestAccAWSEBSSnapshot_withDescription (38.13s)
--- PASS: TestAccAWSEBSSnapshot_withKms (39.02s)

--- PASS: TestAccAWSEbsSnapshotCopy_basic (53.22s)
--- PASS: TestAccAWSEbsSnapshotCopy_disappears (53.87s)
--- PASS: TestAccAWSEbsSnapshotCopy_tags (79.17s)
--- PASS: TestAccAWSEbsSnapshotCopy_withDescription (55.14s)
--- PASS: TestAccAWSEbsSnapshotCopy_withKms (59.40s)
--- PASS: TestAccAWSEbsSnapshotCopy_withRegions (62.44s)

--- PASS: TestAccAWSEbsSnapshotDataSource_basic (38.18s)
--- PASS: TestAccAWSEbsSnapshotDataSource_Filter (38.92s)
--- PASS: TestAccAWSEbsSnapshotDataSource_MostRecent (99.35s)

@bflad bflad merged commit e36b6d2 into hashicorp:master Jun 22, 2020
bflad added a commit that referenced this pull request Jun 22, 2020
@DrFaust92 DrFaust92 deleted the rd/ebs_snapshot_rec_arn branch June 23, 2020 11:11
@ghost
Copy link

ghost commented Jun 26, 2020

This has been released in version 2.68.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants