Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_vpc_endpoint_service: Add 'arn' attribute #13856

Merged

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624.

Release note for CHANGELOG:

data-source/aws_vpc_endpoint-service: Add `arn` attribute

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsVpcEndpointService_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccDataSourceAwsVpcEndpointService_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpcEndpointService_gateway
=== PAUSE TestAccDataSourceAwsVpcEndpointService_gateway
=== RUN   TestAccDataSourceAwsVpcEndpointService_interface
=== PAUSE TestAccDataSourceAwsVpcEndpointService_interface
=== RUN   TestAccDataSourceAwsVpcEndpointService_custom
=== PAUSE TestAccDataSourceAwsVpcEndpointService_custom
=== RUN   TestAccDataSourceAwsVpcEndpointService_custom_filter
=== PAUSE TestAccDataSourceAwsVpcEndpointService_custom_filter
=== RUN   TestAccDataSourceAwsVpcEndpointService_custom_filter_tags
=== PAUSE TestAccDataSourceAwsVpcEndpointService_custom_filter_tags
=== CONT  TestAccDataSourceAwsVpcEndpointService_gateway
=== CONT  TestAccDataSourceAwsVpcEndpointService_custom_filter
--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (23.99s)
=== CONT  TestAccDataSourceAwsVpcEndpointService_custom_filter_tags
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (256.95s)
=== CONT  TestAccDataSourceAwsVpcEndpointService_custom
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (276.82s)
=== CONT  TestAccDataSourceAwsVpcEndpointService_interface
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (24.62s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (255.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	512.280s```

@ewbankkit ewbankkit requested a review from a team June 21, 2020 21:33
@ghost ghost added size/S Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jun 21, 2020
@bflad bflad added this to the v2.68.0 milestone Jun 22, 2020
@bflad bflad self-assigned this Jun 22, 2020
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 22, 2020
@ewbankkit
Copy link
Contributor Author

I'll fix the conflict.

Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (9.87s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (10.29s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (231.84s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (231.87s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (281.87s)

@bflad bflad merged commit 7aae3af into hashicorp:master Jun 23, 2020
bflad added a commit that referenced this pull request Jun 23, 2020
@ewbankkit ewbankkit deleted the td-aws_vpc_endpoint_service-data-source-arn branch June 23, 2020 13:39
@ghost
Copy link

ghost commented Jun 26, 2020

This has been released in version 2.68.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants