provider: Support arbitrary additional tag data, implement keyvaluetags and ignore_tags support in aws_autoscaling_group resource, return empty strings with key-only tags instead of panicking #13868

bflad · 2020-06-22T14:40:18Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12368
Closes #12701
Closes #13808
Closes #14768

Release note for CHANGELOG:

* resource/aws_autoscaling_group: Support provider-level `ignore_tags` configuration
* resource/aws_lightsail_instance: Prevent panic with key-only tags

Output from acceptance testing:

--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (270.49s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (347.98s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (48.39s)
--- PASS: TestAccAWSAutoScalingGroup_basic (240.73s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (57.40s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (301.11s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (203.91s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (262.41s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (80.07s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (100.28s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (141.65s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (80.33s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (835.18s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (108.58s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (54.75s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (83.27s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (86.71s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (84.96s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (47.10s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (89.58s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (85.66s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (75.63s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (48.09s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (87.27s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (90.33s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (177.12s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (77.41s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (43.51s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (210.03s)
--- PASS: TestAccAWSAutoScalingGroup_tags (228.44s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (243.95s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (173.57s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (81.11s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (315.22s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (316.01s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (115.03s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (232.21s)

ewbankkit · 2020-06-22T20:29:48Z

Supercedes:

consolidate tag and tags diff during asg update #3533

bflad · 2020-07-06T19:27:43Z

Rebased and re-verified:

--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (175.59s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (307.41s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (53.58s)
--- PASS: TestAccAWSAutoScalingGroup_basic (271.50s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (81.34s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (63.89s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (158.10s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (272.15s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (51.46s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (59.35s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (172.15s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (53.72s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (556.01s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (97.18s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (84.80s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (84.68s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (142.47s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (110.84s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (57.34s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (84.39s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (147.12s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (89.85s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (48.93s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (83.02s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (146.64s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (169.50s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (91.83s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (81.65s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (235.15s)
--- PASS: TestAccAWSAutoScalingGroup_tags (244.95s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (239.74s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (141.07s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (174.64s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (388.90s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (361.88s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (78.39s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (182.13s)

bflad · 2020-08-20T16:22:29Z

Rebased and re-verified:

--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (179.86s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (333.20s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (51.77s)
--- PASS: TestAccAWSAutoScalingGroup_basic (240.41s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (134.91s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (177.09s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (243.57s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (45.88s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (58.72s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (106.61s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (51.25s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (618.13s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (165.12s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (44.59s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (42.10s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (76.16s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (47.32s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (43.62s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (82.44s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (150.94s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (78.70s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (45.47s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (84.44s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (76.53s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (207.67s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (50.25s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (54.73s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (198.11s)
--- PASS: TestAccAWSAutoScalingGroup_tags (232.54s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (247.63s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (105.39s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (175.27s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (251.24s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (392.43s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (81.00s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (146.95s)

ewbankkit · 2020-08-20T17:00:26Z

aws/internal/keyvaluetags/generators/createtags/main.go

@@ -133,25 +134,27 @@ func isResourceTimeoutError(err error) bool {
 // {{ . | Title }}CreateTags creates {{ . }} service tags for new resources.


isAWSErrCode() and isAWSErrCodeContains() above can also be removed now and replaced by functions in github.com/hashicorp/aws-sdk-go-base/tfawserr.

I have a similar internal package github.com/terraform-providers/terraform-provider-aws/aws/internal/resourceerr in #13036.

Nice yeah. Thanks for the reminder on that -- could you ensure there's a covering GitHub issue for this. I'll save that general refactoring for after this change, since this is already too big. 😭

Oh sorry, now reading #13036 I see this is already a part of that. We'll take a look after this gets in.

ewbankkit · 2020-08-27T18:36:18Z

Is there an opportunity to address #11480 with this one, modifying internal/keyvaluetags/generators/updatetags/main.go, changing updatedTags := oldTags.Updated(newTags) to updatedTags := oldTags.Updated(newTags).IgnoreAws() (and the same for removedTags)?

anGie44

awesome! I second @ewbankkit 's comment to see if the issue re: the special aws: prefixed tags could be easily addressed with these changes, otherwise as-is (aside from the 1 emerging merge conflict) LGTM 🚀

Output of acceptance tests:

--- PASS: TestAccAWSAutoScalingGroup_namePrefix (45.59s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (64.69s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (69.06s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (104.27s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (110.31s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (113.28s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (117.27s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (70.47s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (154.61s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (118.49s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (178.23s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (183.23s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (81.79s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (52.13s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (201.28s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (55.28s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (210.29s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (110.69s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (105.23s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (224.75s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (40.96s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (122.30s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (238.03s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (75.54s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (58.45s)
--- PASS: TestAccAWSAutoScalingGroup_tags (248.04s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (38.50s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (261.58s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (100.01s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (100.70s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (294.04s)
--- PASS: TestAccAWSAutoScalingGroup_basic (301.35s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (140.95s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (404.02s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (447.12s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (583.19s)

…on, fix nil value panics, implement autoscaling service tags Reference: #12368 Reference: #13808

…ovider ignore_tags Reference: #13808 Output from acceptance testing: ``` --- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (179.86s) --- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (333.20s) --- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (51.77s) --- PASS: TestAccAWSAutoScalingGroup_basic (240.41s) --- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (134.91s) --- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (177.09s) --- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (243.57s) --- PASS: TestAccAWSAutoScalingGroup_launchTemplate (45.88s) --- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (58.72s) --- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (106.61s) --- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (51.25s) --- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (618.13s) --- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (165.12s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (44.59s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (42.10s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (76.16s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (47.32s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (43.62s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (82.44s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (150.94s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (78.70s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (45.47s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (84.44s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (76.53s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (207.67s) --- PASS: TestAccAWSAutoScalingGroup_namePrefix (50.25s) --- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (54.73s) --- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (198.11s) --- PASS: TestAccAWSAutoScalingGroup_tags (232.54s) --- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (247.63s) --- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (105.39s) --- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (175.27s) --- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (251.24s) --- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (392.43s) --- PASS: TestAccAWSAutoScalingGroup_withMetrics (81.00s) --- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (146.95s) ```

bflad · 2020-09-01T00:58:18Z

The changes necessary for #11480 are not related to the intentions of this pull request, but a followup can certainly be submitted with covering acceptance test(s). 👍

ghost · 2020-09-03T19:30:10Z

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-10-01T17:10:58Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 22, 2020

bflad requested a review from a team June 22, 2020 14:40

This was referenced Jun 22, 2020

[WIP] New package for Autoscaling tags functionality #13508

Closed

Add namevaluesfilters package for resource filtering code #13304

Closed

This was referenced Jun 24, 2020

consolidate tag and tags diff during asg update #3533

Closed

r/aws_lightsail_instance: Fix crash when encountering key-only tags #12346

Merged

bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Jun 25, 2020

bflad force-pushed the f-keyvaluetags-autoscaling branch from 91f02a9 to a22c22b Compare July 6, 2020 19:27

bflad mentioned this pull request Jul 7, 2020

Terraform crashing when creating bucket in MinIO #12701

Closed

anGie44 force-pushed the master branch from 54db70d to 48ba2f7 Compare July 21, 2020 18:26

bflad force-pushed the f-keyvaluetags-autoscaling branch from a22c22b to d4a6d1e Compare August 20, 2020 16:22

ewbankkit reviewed Aug 20, 2020

View reviewed changes

ewbankkit mentioned this pull request Aug 21, 2020

Autoscaling group tags are destroyed and recreated for an update in-place #14768

Closed

anGie44 approved these changes Aug 31, 2020

View reviewed changes

bflad added 2 commits August 31, 2020 20:05

internal/keyvaluetags: Implement support for additional tag informati…

7e0a078

…on, fix nil value panics, implement autoscaling service tags Reference: #12368 Reference: #13808

bflad force-pushed the f-keyvaluetags-autoscaling branch from d4a6d1e to d51ee66 Compare September 1, 2020 00:23

bflad added this to the v3.5.0 milestone Sep 1, 2020

bflad merged commit e446592 into master Sep 1, 2020

bflad deleted the f-keyvaluetags-autoscaling branch September 1, 2020 00:59

bflad added a commit that referenced this pull request Sep 1, 2020

Update CHANGELOG for #13868

e3e5b5d

ghost locked as resolved and limited conversation to collaborators Oct 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provider: Support arbitrary additional tag data, implement keyvaluetags and ignore_tags support in aws_autoscaling_group resource, return empty strings with key-only tags instead of panicking #13868

provider: Support arbitrary additional tag data, implement keyvaluetags and ignore_tags support in aws_autoscaling_group resource, return empty strings with key-only tags instead of panicking #13868

bflad commented Jun 22, 2020 •

edited

ewbankkit commented Jun 22, 2020

bflad commented Jul 6, 2020

bflad commented Aug 20, 2020

ewbankkit Aug 20, 2020 •

edited

bflad Aug 21, 2020

bflad Aug 21, 2020

ewbankkit commented Aug 27, 2020

anGie44 left a comment •

edited

bflad commented Sep 1, 2020

ghost commented Sep 3, 2020

ghost commented Oct 1, 2020

		@@ -133,25 +134,27 @@ func isResourceTimeoutError(err error) bool {
		// {{ . \| Title }}CreateTags creates {{ . }} service tags for new resources.

provider: Support arbitrary additional tag data, implement keyvaluetags and ignore_tags support in aws_autoscaling_group resource, return empty strings with key-only tags instead of panicking #13868

provider: Support arbitrary additional tag data, implement keyvaluetags and ignore_tags support in aws_autoscaling_group resource, return empty strings with key-only tags instead of panicking #13868

Conversation

bflad commented Jun 22, 2020 • edited

Community Note

ewbankkit commented Jun 22, 2020

bflad commented Jul 6, 2020

bflad commented Aug 20, 2020

ewbankkit Aug 20, 2020 • edited

Choose a reason for hiding this comment

bflad Aug 21, 2020

Choose a reason for hiding this comment

bflad Aug 21, 2020

Choose a reason for hiding this comment

ewbankkit commented Aug 27, 2020

anGie44 left a comment • edited

Choose a reason for hiding this comment

bflad commented Sep 1, 2020

ghost commented Sep 3, 2020

ghost commented Oct 1, 2020

bflad commented Jun 22, 2020 •

edited

ewbankkit Aug 20, 2020 •

edited

anGie44 left a comment •

edited