Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/wafv2_web_acl: add additional nested statement level #13961

Merged
merged 3 commits into from Jun 29, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jun 26, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13862

Release note for CHANGELOG:

resource/wafv2_web_acl: add missing nested statement level

Output from acceptance testing:

--- PASS: TestAccAwsWafv2WebACL_Basic (731.65s)
--- PASS: TestAccAwsWafv2WebACL_ChangeNameForceNew (532.66s)
--- PASS: TestAccAwsWafv2WebACL_MaxNestedRateBasedStatements (289.54s)
--- PASS: TestAccAwsWafv2WebACL_MaxNestedOperatorStatements (277.27s)
--- PASS: TestAccAwsWafv2WebACL_Disappears (149.59s)
--- PASS: TestAccAwsWafv2WebACL_ManagedRuleGroupStatement (657.62s)
--- PASS: TestAccAwsWafv2WebACL_Minimal (225.93s)
--- PASS: TestAccAwsWafv2WebACL_RateBasedStatement (688.45s)
--- PASS: TestAccAwsWafv2WebACL_RuleGroupReferenceStatement (737.43s)
--- PASS: TestAccAwsWafv2WebACL_Tags (852.06s)

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/wafv2 Issues and PRs that pertain to the wafv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 26, 2020
@anGie44 anGie44 changed the title add additional nested level resource/wafv2_web_acl: add additional nested statement level Jun 26, 2020
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jun 26, 2020
@anGie44 anGie44 marked this pull request as ready for review June 26, 2020 22:58
@anGie44 anGie44 requested a review from a team June 26, 2020 22:58
@bflad bflad added the bug Addresses a defect in current functionality. label Jun 29, 2020
@bflad bflad self-assigned this Jun 29, 2020
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing (I think the super long times are due to some unrelated restore work happening on the server):

--- PASS: TestAccAwsWafv2WebACL_Disappears (2309.07s)
--- PASS: TestAccAwsWafv2WebACL_Minimal (3268.81s)
--- PASS: TestAccAwsWafv2WebACL_MaxNestedRateBasedStatements (3672.83s)
--- PASS: TestAccAwsWafv2WebACL_MaxNestedOperatorStatements (3688.38s)
--- PASS: TestAccAwsWafv2WebACL_ChangeNameForceNew (5275.11s)
--- PASS: TestAccAwsWafv2WebACL_ManagedRuleGroupStatement (5729.62s)
--- PASS: TestAccAwsWafv2WebACL_RateBasedStatement (5762.11s)
--- PASS: TestAccAwsWafv2WebACL_Basic (5843.51s)
--- PASS: TestAccAwsWafv2WebACL_RuleGroupReferenceStatement (5857.32s)
--- PASS: TestAccAwsWafv2WebACL_Tags (6016.74s)

@anGie44 anGie44 merged commit 081bf57 into master Jun 29, 2020
@anGie44 anGie44 added this to the v2.69.0 milestone Jun 29, 2020
anGie44 added a commit that referenced this pull request Jun 29, 2020
@anGie44 anGie44 deleted the b-wafv2-web-acl-recursion branch June 29, 2020 16:15
@ghost
Copy link

ghost commented Jul 3, 2020

This has been released in version 2.69.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing support for nested NOT/AND/OR rule statements with WAFv2
2 participants