resource/aws_rds_global_cluster: Add force_destroy and source_db_cluster_identifier arguments, add global_cluster_members attribute #14487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
the
enhancement
ghost
added
size/L
|
@bflad Which AWS provider version are you planning to release this in? |
…ter_identifier arguments, add global_cluster_members attribute Reference: #10965 Output from acceptance testing: ``` --- PASS: TestAccAWSRdsGlobalCluster_disappears (11.01s) --- PASS: TestAccAWSRdsGlobalCluster_Engine_Aurora (14.06s) --- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraPostgresql (14.18s) --- PASS: TestAccAWSRdsGlobalCluster_basic (14.27s) --- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraMySQL (14.55s) --- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_Aurora (14.72s) --- PASS: TestAccAWSRdsGlobalCluster_DeletionProtection (21.99s) --- PASS: TestAccAWSRdsGlobalCluster_DatabaseName (23.70s) --- PASS: TestAccAWSRdsGlobalCluster_StorageEncrypted (25.16s) --- PASS: TestAccAWSRdsGlobalCluster_SourceDbClusterIdentifier (168.11s) ```
bflad
force-pushed
the
f-aws_rds_global_cluster-source_db_cluster_identifier
branch
from
9341ff3
to
106cc5d
Compare
anGie44
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
LGTM 👍
Output of acceptance tests:
--- PASS: TestAccAWSRdsGlobalCluster_DatabaseName (24.07s)
--- PASS: TestAccAWSRdsGlobalCluster_DeletionProtection (24.72s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_Aurora (18.20s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraMySQL (17.95s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraPostgresql (17.04s)
--- PASS: TestAccAWSRdsGlobalCluster_Engine_Aurora (17.20s)
--- PASS: TestAccAWSRdsGlobalCluster_SourceDbClusterIdentifier (160.59s)
--- PASS: TestAccAWSRdsGlobalCluster_StorageEncrypted (25.82s)
--- PASS: TestAccAWSRdsGlobalCluster_basic (17.98s)
--- PASS: TestAccAWSRdsGlobalCluster_disappears (14.17s)
| "global_cluster_identifier": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ForceNew: true, | ||
| }, | ||
| "global_cluster_members": { |
|
This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #10965
Release note for CHANGELOG:
Attempting to add
Computed: trueto theaws_rds_clusterresource to match the Terraform core contract that the value will be potentially filled in by the API outside of configuration prevents practitioners from being able to successfully remove a DB Cluster from the Global Cluster, even with setting the value to"". This is likely a bug in the Terraform Plugin SDK, but its behavior has likely been present for so long that attempting to fix it would present its own major problems for providers. For now, just documentignore_changesas the implementation.Output from acceptance testing: