Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-1146 part b, add resource for emr_instance_fleet #14813

Merged
merged 54 commits into from
Sep 1, 2020

Conversation

c4po
Copy link
Contributor

@c4po c4po commented Aug 24, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #1146

Release note for CHANGELOG:

* new resource: aws_emr_instance_fleet

acceptance test will depend on the 14788 be merged.
Output from acceptance testing:

% make testacc TESTARGS='-run=TestAccAWSEMRInstanceFleet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEMRInstanceFleet_basic -timeout 120m
=== RUN   TestAccAWSEMRInstanceFleet_basic
=== PAUSE TestAccAWSEMRInstanceFleet_basic
=== CONT  TestAccAWSEMRInstanceFleet_basic
2020/08/31 15:20:11 [INFO] Test: Using us-east-1 as test region
2020/08/31 15:20:11 [INFO] AWS Auth provider used: "EnvProvider"
--- PASS: TestAccAWSEMRInstanceFleet_basic (559.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	559.594s

 make testacc TESTARGS='-run=TestAccAWSEMRInstanceFleet_zero_count'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEMRInstanceFleet_zero_count -timeout 120m
=== RUN   TestAccAWSEMRInstanceFleet_zero_count
=== PAUSE TestAccAWSEMRInstanceFleet_zero_count
=== CONT  TestAccAWSEMRInstanceFleet_zero_count
2020/08/31 16:57:37 [INFO] Test: Using us-east-1 as test region
2020/08/31 16:57:37 [INFO] AWS Auth provider used: "EnvProvider"
--- PASS: TestAccAWSEMRInstanceFleet_zero_count (788.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	788.718s

% make testacc TESTARGS='-run=TestAccAWSEMRInstanceFleet_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEMRInstanceFleet_disappears -timeout 120m
=== RUN   TestAccAWSEMRInstanceFleet_disappears
=== PAUSE TestAccAWSEMRInstanceFleet_disappears
=== CONT  TestAccAWSEMRInstanceFleet_disappears
2020/09/01 09:37:25 [INFO] Test: Using us-east-1 as test region
2020/09/01 09:37:25 [INFO] AWS Auth provider used: "EnvProvider"
--- PASS: TestAccAWSEMRInstanceFleet_disappears (500.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	500.819s

@c4po c4po requested a review from a team August 24, 2020 19:37
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/emr Issues and PRs that pertain to the emr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Aug 24, 2020
@bflad bflad added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 24, 2020
@bflad bflad self-assigned this Aug 24, 2020
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Aug 31, 2020
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again 👋 Please see the below initial feedback and let us know if you have any questions or do not have time to implement the items. 👍

aws/resource_aws_emr_instance_fleet.go Outdated Show resolved Hide resolved
aws/resource_aws_emr_instance_fleet.go Outdated Show resolved Hide resolved
aws/resource_aws_emr_instance_fleet.go Outdated Show resolved Hide resolved
aws/resource_aws_emr_instance_fleet.go Outdated Show resolved Hide resolved
aws/resource_aws_emr_instance_fleet.go Outdated Show resolved Hide resolved
aws/resource_aws_emr_instance_fleet_test.go Outdated Show resolved Hide resolved
aws/resource_aws_emr_instance_fleet_test.go Outdated Show resolved Hide resolved
aws/resource_aws_emr_instance_fleet_test.go Outdated Show resolved Hide resolved
aws/resource_aws_emr_instance_fleet_test.go Outdated Show resolved Hide resolved
aws/resource_aws_emr_instance_fleet_test.go Outdated Show resolved Hide resolved
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Aug 31, 2020
@c4po c4po requested a review from bflad August 31, 2020 19:33
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Aug 31, 2020
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty close! Just needs import testing/documentation and left two other simplification suggestions. 👍 Acceptance testing is passing.

aws/resource_aws_emr_instance_fleet.go Show resolved Hide resolved
aws/resource_aws_emr_instance_fleet.go Outdated Show resolved Hide resolved
aws/resource_aws_emr_instance_fleet.go Outdated Show resolved Hide resolved
@bflad bflad added this to the v3.5.0 milestone Sep 1, 2020
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Sep 1, 2020
@c4po c4po requested a review from bflad September 1, 2020 03:23
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- nice work @c4po 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEMRInstanceFleet_full (465.80s)
--- PASS: TestAccAWSEMRInstanceFleet_ebsBasic (475.54s)
--- PASS: TestAccAWSEMRInstanceFleet_disappears (486.69s)
--- PASS: TestAccAWSEMRInstanceFleet_basic (523.79s)
--- PASS: TestAccAWSEMRInstanceFleet_zero_count (559.72s)

@bflad bflad merged commit 45ee110 into hashicorp:master Sep 1, 2020
bflad added a commit that referenced this pull request Sep 1, 2020
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/emr Issues and PRs that pertain to the emr service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants