r/glue_connection - Add support network connection type + disappears test

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14769
Relates #13826
Relates #14601

Release note for CHANGELOG:

resource_aws_glue_connection - support `NETWORK` connection type

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueConnection_'
--- PASS: TestAccAWSGlueConnection_basic (66.82s)
--- PASS: TestAccAWSGlueConnection_MongoDB (56.21s)
--- PASS: TestAccAWSGlueConnection_Kafka (50.82s)
--- PASS: TestAccAWSGlueConnection_Description (82.73s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (120.87s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (571.28s)
--- PASS: TestAccAWSGlueConnection_disappears (39.92s)

[ewbankkit]

Relates: #14601.

[ewbankkit]

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueConnection_ -timeout 120m
=== RUN   TestAccAWSGlueConnection_basic
=== PAUSE TestAccAWSGlueConnection_basic
=== RUN   TestAccAWSGlueConnection_MongoDB
=== PAUSE TestAccAWSGlueConnection_MongoDB
=== RUN   TestAccAWSGlueConnection_Kafka
=== PAUSE TestAccAWSGlueConnection_Kafka
=== RUN   TestAccAWSGlueConnection_Description
=== PAUSE TestAccAWSGlueConnection_Description
=== RUN   TestAccAWSGlueConnection_MatchCriteria
=== PAUSE TestAccAWSGlueConnection_MatchCriteria
=== RUN   TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== PAUSE TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== RUN   TestAccAWSGlueConnection_disappears
=== PAUSE TestAccAWSGlueConnection_disappears
=== CONT  TestAccAWSGlueConnection_basic
=== CONT  TestAccAWSGlueConnection_MatchCriteria
=== CONT  TestAccAWSGlueConnection_Description
=== CONT  TestAccAWSGlueConnection_Kafka
=== CONT  TestAccAWSGlueConnection_MongoDB
=== CONT  TestAccAWSGlueConnection_disappears
=== CONT  TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== CONT  TestAccAWSGlueConnection_disappears
    resource_aws_glue_connection_test.go:282: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueConnection_disappears (24.72s)
--- PASS: TestAccAWSGlueConnection_basic (33.63s)
--- PASS: TestAccAWSGlueConnection_Kafka (33.71s)
--- PASS: TestAccAWSGlueConnection_MongoDB (33.76s)
--- PASS: TestAccAWSGlueConnection_Description (45.56s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (56.30s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (565.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	565.412s

[breathingdust]

LGTM! 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSGlueConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueConnection_ -timeout 120m
=== RUN   TestAccAWSGlueConnection_basic
=== PAUSE TestAccAWSGlueConnection_basic
=== RUN   TestAccAWSGlueConnection_MongoDB
=== PAUSE TestAccAWSGlueConnection_MongoDB
=== RUN   TestAccAWSGlueConnection_Kafka
=== PAUSE TestAccAWSGlueConnection_Kafka
=== RUN   TestAccAWSGlueConnection_Description
=== PAUSE TestAccAWSGlueConnection_Description
=== RUN   TestAccAWSGlueConnection_MatchCriteria
=== PAUSE TestAccAWSGlueConnection_MatchCriteria
=== RUN   TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== PAUSE TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== RUN   TestAccAWSGlueConnection_disappears
=== PAUSE TestAccAWSGlueConnection_disappears
=== CONT  TestAccAWSGlueConnection_basic
=== CONT  TestAccAWSGlueConnection_MatchCriteria
=== CONT  TestAccAWSGlueConnection_disappears
=== CONT  TestAccAWSGlueConnection_Kafka
=== CONT  TestAccAWSGlueConnection_Description
=== CONT  TestAccAWSGlueConnection_MongoDB
=== CONT  TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== CONT  TestAccAWSGlueConnection_disappears
    resource_aws_glue_connection_test.go:282: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueConnection_disappears (12.24s)
--- PASS: TestAccAWSGlueConnection_basic (15.67s)
--- PASS: TestAccAWSGlueConnection_MongoDB (16.88s)
--- PASS: TestAccAWSGlueConnection_Kafka (17.75s)
--- PASS: TestAccAWSGlueConnection_Description (27.98s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (35.97s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (651.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	653.558s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTARGS='-run=TestAccAWSGlueConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueConnection_ -timeout 120m
=== RUN   TestAccAWSGlueConnection_basic
=== PAUSE TestAccAWSGlueConnection_basic
=== RUN   TestAccAWSGlueConnection_MongoDB
=== PAUSE TestAccAWSGlueConnection_MongoDB
=== RUN   TestAccAWSGlueConnection_Kafka
=== PAUSE TestAccAWSGlueConnection_Kafka
=== RUN   TestAccAWSGlueConnection_Description
=== PAUSE TestAccAWSGlueConnection_Description
=== RUN   TestAccAWSGlueConnection_MatchCriteria
=== PAUSE TestAccAWSGlueConnection_MatchCriteria
=== RUN   TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== PAUSE TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== RUN   TestAccAWSGlueConnection_disappears
=== PAUSE TestAccAWSGlueConnection_disappears
=== CONT  TestAccAWSGlueConnection_basic
=== CONT  TestAccAWSGlueConnection_MatchCriteria
=== CONT  TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== CONT  TestAccAWSGlueConnection_Kafka
=== CONT  TestAccAWSGlueConnection_Description
=== CONT  TestAccAWSGlueConnection_disappears
=== CONT  TestAccAWSGlueConnection_MongoDB
=== CONT  TestAccAWSGlueConnection_disappears
    resource_aws_glue_connection_test.go:282: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueConnection_disappears (9.43s)
--- PASS: TestAccAWSGlueConnection_basic (12.75s)
--- PASS: TestAccAWSGlueConnection_MongoDB (12.95s)
--- PASS: TestAccAWSGlueConnection_Kafka (13.19s)
--- PASS: TestAccAWSGlueConnection_Description (19.59s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (26.15s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (616.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	617.819s

[ghost]

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!