Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/rds_cluster_endpoint: add Create Timeout #14862

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Aug 27, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14570

Release note for CHANGELOG:

resource/rds_cluster_endpoint: increase Create Timeout to 30 minutes

Output from acceptance testing:

--- PASS: TestAccAWSRDSClusterEndpoint_basic (1160.15s)
--- PASS: TestAccAWSRDSClusterEndpoint_tags (1218.53s)

@anGie44 anGie44 requested a review from a team August 27, 2020 01:57
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. documentation Introduces or discusses updates to documentation. labels Aug 27, 2020
@bflad
Copy link
Member

bflad commented Aug 27, 2020

@anGie44 is the creation time dependent on something practitioners manage (e.g. database size)? Typically we want to avoid providing customizable timeouts when operators have no influence/need to adjust it.

@anGie44
Copy link
Contributor Author

anGie44 commented Aug 27, 2020

good question @bflad! as far as i could tell the cluster/instance specs don't directly affect this creation time. as part of the issue's task, I interpreted the 2nd bullet point as if this timeout should be customizable by users but since there's no overall effect, will remove the Timeout from the resource schema 👍

@bflad
Copy link
Member

bflad commented Aug 27, 2020

@anGie44 oh that's my bad on that second bullet point in the issue -- copypasta from another issue 🍝 😖

@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Aug 27, 2020
@bflad bflad self-assigned this Aug 28, 2020
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

Output from acceptance testing:

--- PASS: TestAccAWSRDSClusterEndpoint_basic (1119.73s)
--- PASS: TestAccAWSRDSClusterEndpoint_tags (1120.53s)

@anGie44 anGie44 merged commit d697785 into master Aug 28, 2020
@anGie44 anGie44 added this to the v3.5.0 milestone Aug 28, 2020
anGie44 added a commit that referenced this pull request Aug 28, 2020
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 28, 2020
@anGie44 anGie44 deleted the td-rds-cluster-endpoint branch December 3, 2020 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_rds_cluster_endpoint: Increase Default Create Timeout
2 participants