Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuring-enhanced-monitoring to Neptune instance pending states #15284

Merged

Conversation

mvanzoest-rcd
Copy link
Contributor

@mvanzoest-rcd mvanzoest-rcd commented Sep 22, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15283

Release note for CHANGELOG:

Add "configuring-enhanced-monitoring" to Neptune cluster instance create/update pending states

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSNeptuneClusterInstance'

--- PASS: TestAccAWSNeptuneClusterInstance_generatedName (697.19s)
--- PASS: TestAccAWSNeptuneClusterInstance_withSubnetGroup (756.74s)
--- PASS: TestAccAWSNeptuneClusterInstance_namePrefix (798.23s)
--- PASS: TestAccAWSNeptuneClusterInstance_kmsKey (825.04s)
--- PASS: TestAccAWSNeptuneClusterInstance_withaz (887.08s)
--- PASS: TestAccAWSNeptuneClusterInstance_basic (887.68s)

@mvanzoest-rcd mvanzoest-rcd requested a review from a team September 22, 2020 20:11
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/neptune Issues and PRs that pertain to the neptune service. labels Sep 22, 2020
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSNeptuneClusterInstance_generatedName (697.19s)
--- PASS: TestAccAWSNeptuneClusterInstance_withSubnetGroup (756.74s)
--- PASS: TestAccAWSNeptuneClusterInstance_namePrefix (798.23s)
--- PASS: TestAccAWSNeptuneClusterInstance_kmsKey (825.04s)
--- PASS: TestAccAWSNeptuneClusterInstance_withaz (887.08s)
--- PASS: TestAccAWSNeptuneClusterInstance_basic (887.68s)

@gdavison gdavison added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. bug Addresses a defect in current functionality. labels Sep 22, 2020
@gdavison gdavison added this to the v3.8.0 milestone Sep 22, 2020
@gdavison gdavison merged commit 3e5d85b into hashicorp:master Sep 24, 2020
gdavison added a commit that referenced this pull request Sep 24, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/neptune Issues and PRs that pertain to the neptune service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider/aws: aws_neptune_cluster_instance unexpected state when configuring enhanced monitoring
2 participants