Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/aws_organizations_policy:support for tags #15316

Merged
merged 4 commits into from
Sep 24, 2020

Conversation

nikhil-goenka
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #15168

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS='-run=testAccAwsOrganizationsPolicy_tags'
--- PASS: TestAccAwsOrganizationsPolicy_tags (164.96s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       165.341s
...

@nikhil-goenka nikhil-goenka requested a review from a team September 23, 2020 18:50
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/organizations Issues and PRs that pertain to the organizations service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 23, 2020
@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 23, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nikhil-goenka, thank you for this PR! It's looking pretty great, just note you'll need to run go fmt and add the new test to aws/resource_aws_organizations_test.go within the "Policy" test case section to remedy the CI checks.

aws/resource_aws_organizations_policy_test.go Show resolved Hide resolved
@anGie44 anGie44 added the waiting-response Maintainers are waiting on response from community or contributor. label Sep 23, 2020
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Sep 24, 2020
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Sep 24, 2020
@anGie44 anGie44 removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 24, 2020
@anGie44 anGie44 added this to the v3.8.0 milestone Sep 24, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @nikhil-goenka 🚀

Tests passing except for known failure in TestAccAWSOrganizations_serial/Policy/Type_Backup
Output of acceptance tests:

    --- PASS: TestAccAWSOrganizations_serial/Organization (299.23s)
        --- PASS: TestAccAWSOrganizations_serial/Organization/basic (24.35s)
        --- PASS: TestAccAWSOrganizations_serial/Organization/AwsServiceAccessPrincipals (57.70s)
        --- PASS: TestAccAWSOrganizations_serial/Organization/EnabledPolicyTypes (153.75s)
        --- PASS: TestAccAWSOrganizations_serial/Organization/FeatureSet (19.60s)
        --- PASS: TestAccAWSOrganizations_serial/Organization/DataSource (43.84s)
    --- PASS: TestAccAWSOrganizations_serial/Account (0.00s)
        --- SKIP: TestAccAWSOrganizations_serial/Account/basic (0.00s)
        --- SKIP: TestAccAWSOrganizations_serial/Account/ParentId (0.00s)
        --- SKIP: TestAccAWSOrganizations_serial/Account/Tags (0.00s)
    --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit (65.23s)
        --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit/basic (23.85s)
        --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit/Name (41.38s)
    --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnits (0.00s)
        --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnits/DataSource (21.95s)
    --- FAIL: TestAccAWSOrganizations_serial/Policy (280.93s)
        --- PASS: TestAccAWSOrganizations_serial/Policy/concurrent (30.34s)
        --- PASS: TestAccAWSOrganizations_serial/Policy/Description (40.31s)
        --- PASS: TestAccAWSOrganizations_serial/Policy/Tags (74.96s)
        --- PASS: TestAccAWSOrganizations_serial/Policy/Type_AI_OPT_OUT (22.35s)
        --- FAIL: TestAccAWSOrganizations_serial/Policy/Type_Backup (10.29s) -- current failure in master
        --- PASS: TestAccAWSOrganizations_serial/Policy/Type_SCP (38.88s)
        --- PASS: TestAccAWSOrganizations_serial/Policy/Type_Tag (22.21s)
        --- PASS: TestAccAWSOrganizations_serial/Policy/basic (41.59s)
    --- PASS: TestAccAWSOrganizations_serial/PolicyAttachment (113.89s)
        --- PASS: TestAccAWSOrganizations_serial/PolicyAttachment/Account (50.50s)
        --- PASS: TestAccAWSOrganizations_serial/PolicyAttachment/OrganizationalUnit (32.60s)
        --- PASS: TestAccAWSOrganizations_serial/PolicyAttachment/Root (30.79s)

@anGie44 anGie44 merged commit 1fcb9b1 into hashicorp:master Sep 24, 2020
@nikhil-goenka nikhil-goenka deleted the f/aws_organizations_policy branch September 24, 2020 17:11
anGie44 added a commit that referenced this pull request Sep 24, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/organizations Issues and PRs that pertain to the organizations service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_organizations_policy: Add support for resource tags
2 participants