resource/aws_route: Allow adding IPv6 routes to instances and network interfaces

[stevenewey]

Fix for #2264

My first PR, please be kind 😊

[radeksimko]

Hi @stevenewey
thanks for the PR.

Do you mind adding an acceptance test for this bugfix? Feel free to use the config from #2264 and use "copy-paste-modify" approach. Here's an existing test you can copy:

https://github.com/terraform-providers/terraform-provider-aws/blob/b59fa964c12c294c4f83b39527c715d0c3726ec8/aws/resource_aws_route_test.go#L89-L107

The goal is to have a test which is failing prior to your patch and passing after patch. 😉

Let me know if you need any further help.

[stevenewey]

Thanks for the pointer @radeksimko!

The tests run on master...

~/go/src/github.com/terraform-providers/terraform-provider-aws(master) $ TF_ACC=1 go test github.com/terraform-providers/terraform-provider-aws/aws -v -run 'TestAccAWSRoute_ipv6ToInstance'
=== RUN   TestAccAWSRoute_ipv6ToInstance
--- FAIL: TestAccAWSRoute_ipv6ToInstance (144.12s)
	testing.go:503: Step 0 error: Error applying: 1 error(s) occurred:

		* aws_route.internal-default-route-ipv6: 1 error(s) occurred:

		* aws_route.internal-default-route-ipv6: Error creating route: MissingParameter: The request must contain the parameter destinationCidrBlock or destinationIpv6CidrBlock
			status code: 400, request id: 973ea2d4-bbbb-472a-9ead-2af0ad769360
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	144.153s
~/go/src/github.com/terraform-providers/terraform-provider-aws(master) $ TF_ACC=1 go test github.com/terraform-providers/terraform-provider-aws/aws -v -run 'TestAccAWSRoute_ipv6ToNetworkInterface'
=== RUN   TestAccAWSRoute_ipv6ToNetworkInterface
--- FAIL: TestAccAWSRoute_ipv6ToNetworkInterface (194.86s)
	testing.go:503: Step 0 error: Error applying: 1 error(s) occurred:

		* aws_route.internal-default-route-ipv6: 1 error(s) occurred:

		* aws_route.internal-default-route-ipv6: Error creating route: MissingParameter: The request must contain the parameter destinationCidrBlock or destinationIpv6CidrBlock
			status code: 400, request id: 4f35b513-17f0-414f-9e0d-dd828e5d8634
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	194.893s

And on my branch...

~/go/src/github.com/terraform-providers/terraform-provider-aws(route-ipv6) $ TF_ACC=1 go test github.com/terraform-providers/terraform-provider-aws/aws -v -run 'TestAccAWSRoute_ipv6ToInstance'
=== RUN   TestAccAWSRoute_ipv6ToInstance
--- PASS: TestAccAWSRoute_ipv6ToInstance (142.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	142.946s
~/go/src/github.com/terraform-providers/terraform-provider-aws(route-ipv6) $ TF_ACC=1 go test github.com/terraform-providers/terraform-provider-aws/aws -v -run 'TestAccAWSRoute_ipv6ToNetworkInterface'
=== RUN   TestAccAWSRoute_ipv6ToNetworkInterface
--- PASS: TestAccAWSRoute_ipv6ToNetworkInterface (210.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	210.399s

[stevenewey]

Hi @radeksimko
Are my acceptance tests sufficient, or do I need to do more?
Thanks.

[mindw]

Is there anything missing here?
Thanks!

[bflad]

LGTM! Thanks for adding the acceptance tests!

 make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRoute_ -timeout 120m
=== RUN   TestAccAWSRoute_basic
--- PASS: TestAccAWSRoute_basic (38.67s)
=== RUN   TestAccAWSRoute_ipv6Support
--- PASS: TestAccAWSRoute_ipv6Support (29.11s)
=== RUN   TestAccAWSRoute_ipv6ToInternetGateway
--- PASS: TestAccAWSRoute_ipv6ToInternetGateway (38.24s)
=== RUN   TestAccAWSRoute_ipv6ToInstance
--- PASS: TestAccAWSRoute_ipv6ToInstance (166.32s)
=== RUN   TestAccAWSRoute_ipv6ToNetworkInterface
--- PASS: TestAccAWSRoute_ipv6ToNetworkInterface (188.57s)
=== RUN   TestAccAWSRoute_ipv6ToPeeringConnection
--- PASS: TestAccAWSRoute_ipv6ToPeeringConnection (28.88s)
=== RUN   TestAccAWSRoute_changeCidr
--- PASS: TestAccAWSRoute_changeCidr (54.87s)
=== RUN   TestAccAWSRoute_noopdiff
--- PASS: TestAccAWSRoute_noopdiff (114.88s)
=== RUN   TestAccAWSRoute_doesNotCrashWithVPCEndpoint
--- PASS: TestAccAWSRoute_doesNotCrashWithVPCEndpoint (41.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	701.139s

[bflad]

This has been released in terraform-provider-aws version 1.8.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!