Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_codebuild_project: Prevent crash on empty source buildspec and location #3011

Merged
merged 2 commits into from Jan 17, 2018
Merged

resource/aws_codebuild_project: Prevent crash on empty source buildspec and location #3011

merged 2 commits into from Jan 17, 2018

Conversation

bflad
Copy link
Member

@bflad bflad commented Jan 16, 2018

Also simplifies flattenAwsCodebuildProjectSource and moves Set Hash declarations to schema.

Closes #2673

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildProject_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCodeBuildProject_ -timeout 120m
=== RUN   TestAccAWSCodeBuildProject_basic
--- PASS: TestAccAWSCodeBuildProject_basic (39.20s)
=== RUN   TestAccAWSCodeBuildProject_default_build_timeout
--- PASS: TestAccAWSCodeBuildProject_default_build_timeout (36.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	76.212s

@bflad
resource/aws_codebuild_project: Prevent crash on empty source buildsp…
e169a97 
…ec and location

Also simplifies flattenAwsCodebuildProjectSource and moves Set Hash declarations to schema
@bflad bflad added crash Results from or addresses a Terraform crash or kernel panic. service/codebuild Issues and PRs that pertain to the codebuild service. labels Jan 16, 2018
@bflad bflad added this to the v1.7.1 milestone Jan 16, 2018
@bflad bflad requested a review from radeksimko January 16, 2018 20:08
radeksimko
radeksimko suggested changes Jan 17, 2018
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise LGTM.

aws/resource_aws_codebuild_project.go Outdated
return err
}

d.Set("source", flattenAwsCodebuildProjectSource(project.Source))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the error check can be actually helpful here. 😺

The convention we tend to follow is to have an error check for any fields which have nested fields under them. Not necessarily simple []string but anything that has a potential of breaking - which is this case IMO.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I'll get that back in there. 🚀

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Jan 17, 2018
@bflad
Copy link
Member Author

bflad commented Jan 17, 2018

Ready for re-review! :shipit:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildProject_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCodeBuildProject_ -timeout 120m
=== RUN   TestAccAWSCodeBuildProject_basic
--- PASS: TestAccAWSCodeBuildProject_basic (39.06s)
=== RUN   TestAccAWSCodeBuildProject_default_build_timeout
--- PASS: TestAccAWSCodeBuildProject_default_build_timeout (37.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	76.488s

@bflad bflad requested a review from radeksimko January 17, 2018 14:20
radeksimko
radeksimko approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@bflad bflad merged commit 732bac4 into master Jan 17, 2018
@bflad bflad deleted the b-aws_codebuild_project-source-crash-fix branch January 17, 2018 14:59
bflad added a commit that referenced this pull request Jan 17, 2018
@bflad
Update CHANGELOG for #3011
f742966
@bflad
Copy link
Member Author

bflad commented Jan 22, 2018

This has been released in terraform-provider-aws version 1.7.1. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

drewsonne pushed a commit to drewsonne/terraform-provider-aws that referenced this pull request Mar 3, 2018
@bflad @drewsonne
Update CHANGELOG for hashicorp#3011
af064df
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/codebuild Issues and PRs that pertain to the codebuild service.
Projects
None yet
Milestone
v1.7.1
2 participants
@bflad @radeksimko