Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_kms_alias: Add target_key_arn attribute #3096

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 22, 2018

Simple followup to #2551 to add target_key_arn attribute to the aws_kms_alias resource as well. We would need to augment testAccCheckAWSKmsAliasExists in the acceptance testing to pass back a kms.ListAliasEntry or similar in order to properly check the new attribute value from the existing key ID value (I don't mind implementing this though).

make testacc TEST=./aws TESTARGS='-run=TestAccAWSKmsAlias'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSKmsAlias -timeout 120m
=== RUN   TestAccAWSKmsAlias_importBasic
--- PASS: TestAccAWSKmsAlias_importBasic (43.47s)
=== RUN   TestAccAWSKmsAlias_basic
--- PASS: TestAccAWSKmsAlias_basic (50.60s)
=== RUN   TestAccAWSKmsAlias_name_prefix
--- PASS: TestAccAWSKmsAlias_name_prefix (39.43s)
=== RUN   TestAccAWSKmsAlias_no_name
--- PASS: TestAccAWSKmsAlias_no_name (39.46s)
=== RUN   TestAccAWSKmsAlias_multiple
--- PASS: TestAccAWSKmsAlias_multiple (38.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	211.737s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/kms Issues and PRs that pertain to the kms service. labels Jan 22, 2018
Copy link
Member

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bflad bflad added this to the v1.8.0 milestone Jan 25, 2018
@bflad bflad merged commit 6b9f4d0 into master Jan 25, 2018
@bflad bflad deleted the f-aws_kms_alias-target_key_arn-attr branch January 25, 2018 01:15
bflad added a commit that referenced this pull request Jan 25, 2018
@bflad
Copy link
Contributor Author

bflad commented Jan 29, 2018

This has been released in terraform-provider-aws version 1.8.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kms Issues and PRs that pertain to the kms service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants