Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_cloudfront_distribution: Make default_ttl, max_ttl, and min_ttl attributes as optional #3571

Merged
merged 2 commits into from Mar 6, 2018
Merged

resource/aws_cloudfront_distribution: Make default_ttl, max_ttl, and min_ttl attributes as optional #3571

merged 2 commits into from Mar 6, 2018

Conversation

bflad
Copy link
Member

@bflad bflad commented Feb 28, 2018

Closes #1472
Closes #1994

The Default values match:

  • default_ttl API response when no value is provided during creation
  • max_ttl API response when no value is provided during creation
  • min_ttl Web console default (e.g. Use Origin Cache Headers)
9 tests passed (all tests)
=== RUN   TestAccAWSCloudFrontDistribution_HTTP11Config
--- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (1275.68s)
=== RUN   TestAccAWSCloudFrontDistribution_S3Origin
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (1276.50s)
=== RUN   TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (1278.12s)
=== RUN   TestAccAWSCloudFrontDistribution_importBasic
--- PASS: TestAccAWSCloudFrontDistribution_importBasic (1278.84s)
=== RUN   TestAccAWSCloudFrontDistribution_S3OriginWithTags
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (1279.02s)
=== RUN   TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig
--- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (1279.69s)
=== RUN   TestAccAWSCloudFrontDistribution_noOptionalItemsConfig
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (1283.54s)
=== RUN   TestAccAWSCloudFrontDistribution_multiOrigin
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (1303.90s)
=== RUN   TestAccAWSCloudFrontDistribution_customOrigin
--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (1306.06s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service. labels Feb 28, 2018
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Feb 28, 2018
This was referenced Feb 28, 2018
Closed
Closed
@bflad bflad requested a review from a team March 5, 2018 18:34
paddycarver
paddycarver reviewed Mar 5, 2018
View reviewed changes
Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a vague recollection that adding Default requires a migration to avoid users getting a diff from upgrading. Can you confirm whether that is/is not the case?

@bflad
Copy link
Member Author

bflad commented Mar 6, 2018

@paddycarver since the values were required in configurations before, I can't think of why they would the attributes would require some sort of state migration. Am I missing a scenario?

@paddycarver
Copy link
Contributor

Nope, I missed that it was required before.

@bflad bflad merged commit 09b8409 into master Mar 6, 2018
@bflad bflad deleted the f-aws_cloudfront_distribution-optional-ttls branch March 6, 2018 01:34
bflad added a commit that referenced this pull request Mar 6, 2018
@bflad
Update CHANGELOG for #3571
09cf2d2
bflad added a commit that referenced this pull request Mar 6, 2018
@bflad
Minor fixes for #3571 CHANGELOG
8e1e881
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

terraform miss the Use Origin Cache Headers Allow for default cloudfront TTLs
2 participants
@bflad @paddycarver