resource/aws_s3_bucket_object: mark version_id as recomputed if a new object will be uploaded

[mdlavin]

The version_id attribute of s3 objects should be marked as recomputed when new content will be uploaded so that dependent resources can pick up the change. One example of this is a lambda function that uses versioned resources as the source of the code

Fixes #1696
Fixes #4522

[mdlavin]

I just double checked and this PR still cleanly applies to master and passes the tests. Any chance of a merge soon before a conflict appears?

[kjones1876]

Is there a reason this was not merged. I'd just made a similar change and went to raise a PR before noticing this. I can make any changes needed to get it merged ?

[kjones1876]

@bflad @mdlavin Anything i can do to help ?

[mdlavin]

I wish I knew how to get PRs merged too. I have a handful of PRs that have been open for months with similar comments.

[bflad]

Sorry for the lengthy review delay. LGTM, thanks @mdlavin 🚀

43 tests passed (all tests)
--- PASS: TestAccAWSLambdaFunction_importS3 (21.88s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (23.51s)
--- PASS: TestAccAWSLambdaFunction_VPC (31.34s)
--- PASS: TestAccAWSLambdaFunction_importLocalFile_VPC (33.44s)
--- PASS: TestAccAWSLambdaFunction_importLocalFile (33.48s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (33.73s)
--- PASS: TestAccAWSLambdaFunction_basic (42.51s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (0.51s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (45.26s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (53.67s)
--- PASS: TestAccAWSLambdaFunction_s3 (30.13s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (55.59s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (58.20s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (27.76s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (31.00s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (29.68s)
--- PASS: TestAccAWSS3BucketObject_source (5.74s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (65.39s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (67.50s)
--- PASS: TestAccAWSLambdaFunction_updateRuntime (67.50s)
--- PASS: TestAccAWSS3BucketObject_content (7.69s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (69.24s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (36.44s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (8.08s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_nodeJs43 (29.78s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (51.11s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (77.49s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (24.16s)
--- PASS: TestAccAWSS3BucketObject_sse (12.36s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (80.09s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (18.56s)
--- PASS: TestAccAWSS3BucketObject_tags (10.66s)
--- PASS: TestAccAWSS3BucketObject_storageClass (12.29s)
--- PASS: TestAccAWSS3BucketObject_updates (17.80s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (16.74s)
--- PASS: TestAccAWSS3BucketObject_acl (15.67s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (31.89s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (40.41s)
--- PASS: TestAccAWSLambdaFunction_envVariables (92.74s)
--- PASS: TestAccAWSS3BucketObject_kms (30.76s)
--- PASS: TestAccAWSLambdaFunction_tags (44.87s)
--- PASS: TestAccAWSLambdaFunction_versioned (111.74s)
--- PASS: TestAccAWSLambdaFunction_concurrency (118.29s)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!