Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_ssm_document: Add support for Session document_type #5850

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

gazoakley
Copy link
Contributor

Fixes #5843

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMDocument_session'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMDocument_session -timeout 120m
=== RUN   TestAccAWSSSMDocument_session
--- PASS: TestAccAWSSSMDocument_session (23.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.024s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. labels Sep 12, 2018
@bflad bflad added this to the v1.36.0 milestone Sep 12, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gazoakley! 🚀

10 tests passed (all tests)
--- PASS: TestAccAWSSSMDocument_basic (16.01s)
--- PASS: TestAccAWSSSMDocument_params (22.84s)
--- PASS: TestAccAWSSSMDocument_Tags (25.08s)
--- PASS: TestAccAWSSSMDocument_session (27.38s)
--- PASS: TestAccAWSSSMDocument_automation (29.01s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (29.52s)
--- PASS: TestAccAWSSSMDocument_permission_private (32.48s)
--- PASS: TestAccAWSSSMDocument_update (36.77s)
--- PASS: TestAccAWSSSMDocument_permission_change (39.93s)
--- PASS: TestAccAWSSSMDocument_permission_public (51.14s)

@bflad bflad merged commit 8a237d4 into hashicorp:master Sep 12, 2018
bflad added a commit that referenced this pull request Sep 12, 2018
@bflad
Copy link
Contributor

bflad commented Sep 13, 2018

This has been released in version 1.36.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
@gazoakley gazoakley deleted the f-ssm-session-documents branch April 7, 2020 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for SSM Session Documents/Session Manager Preferences
2 participants