Add an `aws_resource_group` resource for managing AWS resource groups #6217

joestump · 2018-10-19T17:13:22Z

What is the purpose of this PR?

Introduces an aws_resource_group resource.

Example HCL

resource "aws_resource_group" "test" {
  name        = "%s"
  description = "Hello World"

  resource_query {
    query = <<JSON
{
  "ResourceTypeFilters": [
    "AWS::EC2::Instance"
  ],
  "TagFilters": [
    {
      "Key": "Stage",
      "Values": ["Test"]
    }
  ]
}
JSON
  }
}

Test outputs

make testacc TESTARGS='-run=TestAccAWSResourceGroup'
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSResourceGroup -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSResourceGroup_importBasic
=== PAUSE TestAccAWSResourceGroup_importBasic
=== RUN   TestAccAWSResourceGroup_basic
=== PAUSE TestAccAWSResourceGroup_basic
=== CONT  TestAccAWSResourceGroup_importBasic
=== CONT  TestAccAWSResourceGroup_basic
--- PASS: TestAccAWSResourceGroup_basic (17.90s)
--- PASS: TestAccAWSResourceGroup_importBasic (19.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	20.443s

TODO

Merge in vendor: aws/aws-sdk-go@v1.15.57 and add aws/aws-sdk-go/service/resourcegroups@v1.15.57 #6196
Documentation

…cegroups@v1.15.57 Updates: * `govendor fetch github.com/aws/aws-sdk-go/...@v1.15.57` * `govendor fetch github.com/aws/aws-sdk-go/service/resourcegroups@v1.15.57`

…s/terraform-provider-aws into jstump-resource-groups-sdk

bflad

Thanks for submitting this @joestump! Initial feedback left below. Please reach out with any questions.

aws/resource_aws_resource_group.go

aws/resource_aws_resource_group_test.go

aws/provider.go

bflad · 2018-10-19T17:55:20Z

Oh! I would also recommend naming the resource (and updating file names) to aws_resourcegroups_group -- it looks uglier but we have been trying to stick with aws_SERVICE_THING where possible to prevent namespace collisions in the future. See also: aws_organizations_organization 😅

joestump · 2018-10-19T21:33:20Z

@bflad I think comments have been addressed. 👍

bflad

Two more little things and this should be good to go, thanks so much!

aws/resource_aws_resourcegroups_group_test.go

bflad · 2018-10-19T22:34:47Z

website/docs/r/resourcegroups_group.html.markdown

+
+## Import
+
+IAM Users can be imported using the `name`, e.g.


Copypasta here and the example command 🍝 😄

Ha! Literally had that committed about 30 minutes ago and forgot to push. 🤦‍♂️

joestump · 2018-10-20T17:39:04Z

@bflad I've got an interesting issue with this resource. Turns out you can set tags when you call CreateGroup, but GetGroup and ListGroups don't return the groups tags. This is causing the import test to fail if tags are present as it expects tags to be instate, but I can't pull them from the API.

My proposal would be to:

Remove import functionality for now.
Mark tags as ForceNew.

The other option would be to remove this attribute entirely I guess? I've sent an email to our AWS TAM asking they make the tags retrievable.

…re handled.

bflad · 2018-10-30T23:49:57Z

For reading tags, I believe GetTags is what you are looking for, passing in the ARN of the group. For updating tags, I believe Tag and Untag 😄

Otherwise feel free to remove the group tagging bits out for now and we can get in separately.

bflad · 2018-10-31T13:06:18Z

FYI aws/aws-sdk-go/service/resourcegroups is now vendored in via: #6308

joestump · 2018-10-31T13:58:34Z

I'll give GetTags a try with a resource group's ARN. For some reason it hadn't dawned on me that might work.

joestump · 2018-10-31T14:04:20Z

@bflad okay, so looking over these endpoints I've got a new proposal for this. I think we should remove tags from this resource and create two additional resources:

aws_resourcegroups_tags - Data resource that takes an ARN and returns a map of tags for ARN.
aws_resourcegroups_tags - Regular resource that takes an ARN and tags it.

The nice thing about this is that it works for any ARN.

Thoughts?

bflad · 2018-10-31T14:13:52Z

@joestump are you positive that those API calls are intended for outside Resource Groups themselves?

e.g. https://docs.aws.amazon.com/ARG/latest/APIReference/API_GetTags.html

Arn

The ARN of the resource for which you want a list of tags. The resource must exist within the account you are using.

Pattern: arn:aws:resource-groups:[a-z]{2}-[a-z]+-\d{1}:[0-9]{12}:group/[a-zA-Z0-9_.-]{1,128}

https://docs.aws.amazon.com/ARG/latest/APIReference/API_Tag.html

Arn

The ARN of the resource to which to add tags.

Pattern: arn:aws:resource-groups:[a-z]{2}-[a-z]+-\d{1}:[0-9]{12}:group/[a-zA-Z0-9_.-]{1,128}

Either way, the group itself should support tagging via the above.

bflad · 2018-10-31T14:15:35Z

The API for tagging resources via resource groups is separate and can be found here:

joestump · 2018-10-31T21:57:05Z

@bflad BRB learning to read good.

bflad · 2018-11-13T21:05:01Z

Hey @joestump 👋 Will you have time to circle back and finish this up? If not, no problem.

joestump · 2018-11-13T21:07:02Z

@bflad I should be able to. Sorry for the delay, the usual things have kept me from revisiting lately.

bflad

Hey @joestump 👋 Since its been two months and we haven't heard anything, I went ahead and made the minor adjustments (8375b2f) so we could ship at least the initial aws_resourcegroups_group resource without tagging support. I'll create a followup issue for adding that in that you or anyone else can pick. Thanks for your work here! 🚀

Output from acceptance testing:

--- PASS: TestAccAWSResourceGroup_basic (20.04s)

bflad · 2019-01-10T21:55:34Z

This has been released in version 1.55.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

joestump · 2019-02-28T18:48:46Z

@bflad sorry for going MIA. Got slammed with a big deadline at work. I've got tagging with proper tests and whatnot locally. I'll try and clean it up for PR soon!

ghost · 2020-03-31T17:44:02Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

Joe Stump and others added 7 commits October 17, 2018 21:30

Stub out an initial aws_resource_group resource.

8e16b2e

vendor: aws/aws-sdk-go@v1.15.57 and add aws/aws-sdk-go/service/resour…

8756c98

…cegroups@v1.15.57 Updates: * `govendor fetch github.com/aws/aws-sdk-go/...@v1.15.57` * `govendor fetch github.com/aws/aws-sdk-go/service/resourcegroups@v1.15.57`

Merge branch 'v-aws-sdk-go-v1.15.57' of github.com:terraform-provider…

f31860f

…s/terraform-provider-aws into jstump-resource-groups-sdk

Get create, update, and delete stubbed out.

fff4bec

Add a read method.

60a8638

Add some stubbed out tests.

fe62426

Get tests passing.

b682fe2

ghost added dependencies Used to indicate dependency changes. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XXL Managed by automation to categorize the size of a PR. labels Oct 19, 2018

joestump mentioned this pull request Oct 19, 2018

Support for aws resource_group #2972

Closed

joestump changed the title ~~Add an aws_resource_group resource for managing AWS resource groups~~ WIP: Add an aws_resource_group resource for managing AWS resource groups Oct 19, 2018

bflad added new-resource Introduces a new resource. service/resourcegroups Issues and PRs that pertain to the resourcegroups service. labels Oct 19, 2018

bflad reviewed Oct 19, 2018

View reviewed changes

Joe Stump added 5 commits October 19, 2018 13:32

Add initial docs and address a few PR comments.

ed53587

Rename the resource.

356bc56

Reformat with 1.11

1075975

Refactor tests based on PR feedback.

8f4f986

Make errors more descriptive and add a test for updating description.

89ed9f4

ghost added the documentation Introduces or discusses updates to documentation. label Oct 19, 2018

Joe Stump added 2 commits October 19, 2018 15:02

Add a test for updating the resource_query attribute.

edf28be

Add Resource Groups to the sidebar.

1d849b8

joestump changed the title ~~WIP: Add an aws_resource_group resource for managing AWS resource groups~~ Add an aws_resource_group resource for managing AWS resource groups Oct 19, 2018

Fix copy pasta in docs.

b5e7954

bflad reviewed Oct 19, 2018

View reviewed changes

Add a CheckDestroy to tests. Remove importing and refactor how tags a…

f557b45

…re handled.

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Oct 31, 2018

Merge in master and fix conflicts

d6748b7

ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. and removed size/XXL Managed by automation to categorize the size of a PR. labels Nov 15, 2018

bflad removed the dependencies Used to indicate dependency changes. label Nov 21, 2018

bflad mentioned this pull request Dec 12, 2018

Feature request: aws_ssm_resource_group #6834

Closed

bflad added this to the v1.55.0 milestone Jan 10, 2019

bflad approved these changes Jan 10, 2019

View reviewed changes

bflad merged commit d6748b7 into hashicorp:master Jan 10, 2019

bflad mentioned this pull request Jan 10, 2019

Support resource tags for aws_resourcegroups_group resource #7109

Closed

bflad added a commit that referenced this pull request Jan 10, 2019

Update CHANGELOG for #6217

06fb12b

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jan 10, 2019

joestump mentioned this pull request Feb 28, 2019

Add tagging to aws_resourcegroup_group. #7774

Closed

ghost locked and limited conversation to collaborators Mar 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add an `aws_resource_group` resource for managing AWS resource groups #6217

Add an `aws_resource_group` resource for managing AWS resource groups #6217

joestump commented Oct 19, 2018 •

edited

bflad left a comment

bflad commented Oct 19, 2018

joestump commented Oct 19, 2018

bflad left a comment

bflad Oct 19, 2018

joestump Oct 19, 2018

joestump commented Oct 20, 2018 •

edited

bflad commented Oct 30, 2018

bflad commented Oct 31, 2018

joestump commented Oct 31, 2018

joestump commented Oct 31, 2018

bflad commented Oct 31, 2018

bflad commented Oct 31, 2018

joestump commented Oct 31, 2018

bflad commented Nov 13, 2018

joestump commented Nov 13, 2018

bflad left a comment

bflad commented Jan 10, 2019

joestump commented Feb 28, 2019

ghost commented Mar 31, 2020

Add an aws_resource_group resource for managing AWS resource groups #6217

Add an aws_resource_group resource for managing AWS resource groups #6217

Conversation

joestump commented Oct 19, 2018 • edited

What is the purpose of this PR?

Example HCL

Test outputs

TODO

bflad left a comment

Choose a reason for hiding this comment

bflad commented Oct 19, 2018

joestump commented Oct 19, 2018

bflad left a comment

Choose a reason for hiding this comment

bflad Oct 19, 2018

Choose a reason for hiding this comment

joestump Oct 19, 2018

Choose a reason for hiding this comment

joestump commented Oct 20, 2018 • edited

bflad commented Oct 30, 2018

bflad commented Oct 31, 2018

joestump commented Oct 31, 2018

joestump commented Oct 31, 2018

bflad commented Oct 31, 2018

bflad commented Oct 31, 2018

joestump commented Oct 31, 2018

bflad commented Nov 13, 2018

joestump commented Nov 13, 2018

bflad left a comment

Choose a reason for hiding this comment

bflad commented Jan 10, 2019

joestump commented Feb 28, 2019

ghost commented Mar 31, 2020

Add an `aws_resource_group` resource for managing AWS resource groups #6217

Add an `aws_resource_group` resource for managing AWS resource groups #6217

joestump commented Oct 19, 2018 •

edited

joestump commented Oct 20, 2018 •

edited