Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_launch_configuration: Add support for capacity reservations #6325

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

gazoakley
Copy link
Contributor

Fixes #6323

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLaunchTemplate_capacityReservation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSLaunchTemplate_capacityReservation -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_capacityReservation_preference
=== PAUSE TestAccAWSLaunchTemplate_capacityReservation_preference
=== RUN   TestAccAWSLaunchTemplate_capacityReservation_target
=== PAUSE TestAccAWSLaunchTemplate_capacityReservation_target
=== CONT  TestAccAWSLaunchTemplate_capacityReservation_preference
=== CONT  TestAccAWSLaunchTemplate_capacityReservation_target
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (52.77s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (87.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	87.480s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 1, 2018
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @gazoakley! 🚀

--- PASS: TestAccAWSLaunchTemplate_disappears (7.46s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (7.44s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (7.53s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (7.62s)
--- PASS: TestAccAWSLaunchTemplate_basic (7.75s)
--- PASS: TestAccAWSLaunchTemplate_importData (8.03s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (8.00s)
--- PASS: TestAccAWSLaunchTemplate_data (10.15s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (10.84s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (12.99s)
--- PASS: TestAccAWSLaunchTemplate_importBasic (13.97s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (14.45s)
--- PASS: TestAccAWSLaunchTemplate_tags (17.07s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (19.91s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (25.18s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (41.35s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (48.70s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (49.30s)
--- PASS: TestAccAWSLaunchTemplate_update (51.21s)

@bflad bflad added this to the v1.43.0 milestone Nov 1, 2018
@bflad bflad merged commit 4b93067 into hashicorp:master Nov 1, 2018
bflad added a commit that referenced this pull request Nov 1, 2018
@bflad
Copy link
Member

bflad commented Nov 7, 2018

This has been released in version 1.43.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
@gazoakley gazoakley deleted the f-asg-capacity-reservation branch April 7, 2020 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow specifying capacity reservations for launch templates
2 participants