Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for CPU Options to resource aws_launch_template #6552

Merged
merged 2 commits into from
Feb 12, 2020

Conversation

praveensastry
Copy link
Contributor

Fixes #6522

Changes proposed in this pull request:

  • Adding support for CPU Options to resource aws_launch_template

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLaunchTemplate_cpuOptions'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSLaunchTemplate_cpuOptions -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_cpuOptions
=== PAUSE TestAccAWSLaunchTemplate_cpuOptions
=== CONT  TestAccAWSLaunchTemplate_cpuOptions
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (13.73s)
PASS
ok  	github.com/praveensastry/terraform-provider-aws/aws	14.583s
...

@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 22, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 22, 2019
@aeschright aeschright requested a review from a team June 25, 2019 21:37
@Djidiouf
Copy link

Djidiouf commented Oct 9, 2019

Hi @praveensastry what's the status about this issue? Any idea when this one will be merged?

@obi11235
Copy link

I'd also like to see this get merged.

@praveensastry
Copy link
Contributor Author

@bflad Any reason why this is not merged?

@bflad bflad self-assigned this Feb 12, 2020
@bflad bflad added this to the v2.49.0 milestone Feb 12, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this, @praveensastry, and apologies about the delayed review. 😅 LGTM. 🚀

Output from acceptance testing:

--- PASS: TestAccAWSLaunchTemplate_disappears (19.67s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (20.43s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (21.78s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (22.78s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (23.44s)
--- PASS: TestAccAWSLaunchTemplate_data (24.46s)
--- PASS: TestAccAWSLaunchTemplate_basic (25.09s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (25.55s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (25.75s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (26.53s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (27.86s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (28.58s)
--- PASS: TestAccAWSLaunchTemplate_description (30.73s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (31.05s)
--- PASS: TestAccAWSLaunchTemplate_tags (32.30s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (15.61s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (16.28s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (13.24s)
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (43.89s)
--- PASS: TestAccAWSLaunchTemplate_update (48.68s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (49.54s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (52.88s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (55.49s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (42.68s)

@bflad bflad merged commit fbd9336 into hashicorp:master Feb 12, 2020
bflad added a commit that referenced this pull request Feb 12, 2020
@ghost
Copy link

ghost commented Feb 14, 2020

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CPU Options in aws_launch_template
4 participants