Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for aws_ssm_maintenance_window import and documentation #6747

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Add support for aws_ssm_maintenance_window import and documentation #6747

merged 2 commits into from
Dec 12, 2018

Conversation

quercy
Copy link
Contributor

@quercy quercy commented Dec 6, 2018

Changes proposed in this pull request:

  • Add the standard ImportStatePassthrough to the aws_ssm_maintenance_window
  • Update aws_ssm_maintenance_window docs

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ssm Issues and PRs that pertain to the ssm service. documentation Introduces or discusses updates to documentation. labels Dec 6, 2018
@quercy quercy mentioned this pull request Dec 6, 2018
Closed
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 7, 2018
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Dec 7, 2018
@ghost ghost added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Dec 8, 2018
@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 12, 2018
@bflad bflad added this to the v1.52.0 milestone Dec 12, 2018
bflad
bflad approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @quercy! 🚀

--- PASS: TestAccAWSSSMMaintenanceWindowTarget_basic (4.42s)
--- PASS: TestAccAWSSSMMaintenanceWindowTarget_update (6.49s)

@bflad bflad merged commit 3303a51 into hashicorp:master Dec 12, 2018
bflad added a commit that referenced this pull request Dec 12, 2018
@bflad
Update CHANGELOG for #6747
7e57ba8
@bflad
Copy link
Member

bflad commented Dec 13, 2018

This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.52.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quercy @bflad