Add new data source type aws_autoscaling_group

[deberon]

Fixes #6758

Changes proposed in this pull request:

• Add a new data source type called aws_autoscaling_group
• Add documentation for new data source type

Output from acceptance testing:

$ TESTARGS="-run TestAccAwsAutoScalingGroupDataSource_basic" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run TestAccAwsAutoScalingGroupDataSource_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAwsAutoScalingGroupDataSource_basic
=== PAUSE TestAccAwsAutoScalingGroupDataSource_basic
=== CONT  TestAccAwsAutoScalingGroupDataSource_basic
--- PASS: TestAccAwsAutoScalingGroupDataSource_basic (49.77s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       49.786s

[deberon]

And for the sake of consistency, here is the output of the acceptance testing after my second commit:

$ TESTARGS="-run TestAccAwsAutoScalingGroupDataSource_basic" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run TestAccAwsAutoScalingGroupDataSource_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAwsAutoScalingGroupDataSource_basic
=== PAUSE TestAccAwsAutoScalingGroupDataSource_basic
=== CONT  TestAccAwsAutoScalingGroupDataSource_basic
--- PASS: TestAccAwsAutoScalingGroupDataSource_basic (49.55s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       49.565s

[bflad]

Hi @deberon 👋 Thanks for submitting this! I left some initial feedback below. Please let us know if you have any questions or do not have time to implement these items.

[deberon]

Wow! It was my first time writing in Go, could you tell? How do you prefer me to submit my patches? Should I squash the newer commits or do you guys like the verbose history? Thanks for the friendly feedback I will get started on it immediately.

[bflad]

It was my first time writing in Go, could you tell?

Hah, I don't judge, but you did pretty good considering that new fact to me. Setting up a Go environment for the first time, compiling a large project like this one, and developing/running integration testing is no small feat. Great job!

How do you prefer me to submit my patches? Should I squash the newer commits or do you guys like the verbose history?

Verbose history or squashing is fine. We'll merge the commits either which way.

[deberon]

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run TestAccAwsAutoScalingGroupDataSource_basic -timeout 120m
? github.com/terraform-providers/terraform-provider-aws [no test files]
=== RUN TestAccAwsAutoScalingGroupDataSource_basic
=== PAUSE TestAccAwsAutoScalingGroupDataSource_basic
=== CONT TestAccAwsAutoScalingGroupDataSource_basic
--- PASS: TestAccAwsAutoScalingGroupDataSource_basic (51.30s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws (cached)

Also I see there's a conflict on website/aws.erb. I tried to lay my changes over the most current master copy but it's a popular repo.

[bflad]

Great work, @deberon, thanks! 🚀

--- PASS: TestAccAwsAutoScalingGroupDataSource_basic (43.93s)

[bflad]

This has been released in version 1.54.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!