Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for tags for rds snapshots #6881

Merged
merged 2 commits into from
Dec 18, 2018
Merged

add support for tags for rds snapshots #6881

merged 2 commits into from
Dec 18, 2018

Conversation

sunilkumarmohanty
Copy link
Contributor

Fixes #6701

Changes proposed in this pull request:

  • Support for tags for rds snapshots

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDBSnapshot_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDBSnapshot_tags -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDBSnapshot_tags
=== PAUSE TestAccAWSDBSnapshot_tags
=== CONT  TestAccAWSDBSnapshot_tags
--- PASS: TestAccAWSDBSnapshot_tags (805.98s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       806.035s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Dec 17, 2018
bflad
bflad approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sunilkumarmohanty! 🚀

AWS Commercial:

--- PASS: TestAccAWSDBSnapshot_tags (594.14s)
--- PASS: TestAccAWSDBSnapshot_basic (640.22s)

AWS GovCloud (US):

--- PASS: TestAccAWSDBSnapshot_basic (549.61s)
--- PASS: TestAccAWSDBSnapshot_tags (549.63s)

aws/resource_aws_db_snapshot_test.go
password = "barbarbarbar"
username = "foo"

maintenance_window = "Fri:09:00-Fri:09:30"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We should try to omit optional arguments that are not relevant to the acceptance test. 👍

@bflad bflad added this to the v1.53.0 milestone Dec 18, 2018
@bflad bflad merged commit 27a0c0c into hashicorp:master Dec 18, 2018
bflad added a commit that referenced this pull request Dec 18, 2018
@bflad
Update CHANGELOG for #6881
b83071f
@sunilkumarmohanty sunilkumarmohanty deleted the rds-snapshot-tag branch December 19, 2018 04:10
@bflad
Copy link
Member

bflad commented Dec 20, 2018

This has been released in version 1.53.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.53.0
Development

Successfully merging this pull request may close these issues.

Add tags on aws_db_snapshot resource
2 participants
@sunilkumarmohanty @bflad