Add Resource for Cost and Usage Report Definitions

[jbmchuck]

Changes proposed in this pull request:

• Add new resource for Cost and Usage Report Definitions

A separate PR exists for adding the sdk portion: #7433

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsCurReportDefinition_basic'          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAwsCurReportDefinition_basic -timeout 120m
=== RUN   TestAccAwsCurReportDefinition_basic
--- PASS: TestAccAwsCurReportDefinition_basic (33.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsCurReportDefinition_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccDataSourceAwsCurReportDefinition_basic -timeout 120m
=== RUN   TestAccDataSourceAwsCurReportDefinition_basic
=== PAUSE TestAccDataSourceAwsCurReportDefinition_basic
=== CONT  TestAccDataSourceAwsCurReportDefinition_basic
--- PASS: TestAccDataSourceAwsCurReportDefinition_basic (29.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws

[bflad]

Hi @jbmchuck 👋 Thanks for submitting this! This is off to a good start. Please see the below for some initial feedback and let us know if you have any questions or do not have time to implement the items.

[jbmchuck]

Thanks for the feedback! I should be able to get through these today.

[jbmchuck]

@bflad Thanks again for the guidance - I've implemented the suggestions - let me know if there are any other issues. Acceptance test output after the changes:

make testacc TEST=./aws TESTARGS='-run=TestAccAwsCurReportDefinition_basic'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAwsCurReportDefinition_basic -timeout 120m
=== RUN   TestAccAwsCurReportDefinition_basic
--- PASS: TestAccAwsCurReportDefinition_basic (26.35s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws   26.414s

--

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsCurReportDefinition_basic'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccDataSourceAwsCurReportDefinition_basic -timeout 120m
=== RUN   TestAccDataSourceAwsCurReportDefinition_basic
=== PAUSE TestAccDataSourceAwsCurReportDefinition_basic
=== CONT  TestAccDataSourceAwsCurReportDefinition_basic
--- PASS: TestAccDataSourceAwsCurReportDefinition_basic (32.12s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws   32.162s

[bflad]

LGTM, thanks @jbmchuck! 🚀

Maintainer note: I added a PreCheck function for both these acceptance tests so they won't continually fail in our normal acceptance testing account.

Output from standalone AWS account acceptance testing:

--- PASS: TestAccAwsCurReportDefinition_basic (9.46s)
--- PASS: TestAccDataSourceAwsCurReportDefinition_basic (10.61s)

Output from member AWS Organizations account acceptance testing:

--- SKIP: TestAccAwsCurReportDefinition_basic (1.69s)
        resource_aws_cur_report_definition_test.go:99: skipping acceptance testing: AccessDeniedException: accountId: 123456789012 is not authorized to callDescribeReportDefinitions. Note: linked account is not allowed to modify report preference.
                    status code: 400, request id: 2338fb64-4983-4e60-bdb7-42ad4a7cd294
--- SKIP: TestAccDataSourceAwsCurReportDefinition_basic (1.70s)
        resource_aws_cur_report_definition_test.go:99: skipping acceptance testing: AccessDeniedException: accountId: 123456789012 is not authorized to callDescribeReportDefinitions. Note: linked account is not allowed to modify report preference.
                    status code: 400, request id: 9029d7bc-406a-44df-bbda-e1bcf61ca687

[bflad]

This has been released in version 1.59.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[scott-robinson-duke]

Is someone working to add additional compression/format options (Parquet) or additonal artifacts (Athena)? Thanks in advance!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!