fix kinesis firehose input creation

[kl4w]

Fixes #7394

Changes proposed in this pull request:

• fix kinesis firehose input creation

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSKinesisAnalyticsApplication_ -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== RUN   TestAccAWSKinesisAnalyticsApplication_update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_update
=== RUN   TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== CONT  TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== CONT  TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
=== CONT  TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== CONT  TestAccAWSKinesisAnalyticsApplication_update
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (8.35s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (12.82s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (21.44s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (22.09s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (25.56s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (31.62s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (32.78s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (44.93s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (85.13s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (85.13s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (85.29s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose (102.97s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (103.83s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (107.01s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (167.44s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (167.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	167.507s

[bflad]

@kl4w FYI in Terraform 0.12, this syntax is no longer valid for configuration blocks and the configuration upgrade tool will fix it to input {

(same with other configuration blocks in this test configuration)

[bflad]

LGTM, thanks @kl4w 🚀 Will go back and fix the configuration to be 0.12 compatible during next round of acceptance testing.

--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (4.80s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (7.22s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (11.62s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (18.47s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (18.43s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (25.14s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (31.14s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (33.68s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (75.97s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (76.15s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (93.23s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (96.16s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (101.36s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose (103.06s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (150.49s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (150.63s)

[bflad]

This has been released in version 1.60.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!