Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ram_resource_share: Add arn attribute #7634

Merged
merged 1 commit into from
Mar 1, 2019
Merged

resource/aws_ram_resource_share: Add arn attribute #7634

merged 1 commit into from
Mar 1, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 21, 2019

While the ARN was already present in the id attribute, most resources that have an ARN follow the pattern of having an arn attribute.

Output from acceptance testing:

--- PASS: TestAccAwsRamResourceShare_basic (9.85s)
--- PASS: TestAccAwsRamResourceShare_Name (15.21s)
--- PASS: TestAccAwsRamResourceShare_AllowExternalPrincipals (15.60s)
--- PASS: TestAccAwsRamResourceShare_Tags (22.71s)

@bflad
resource/aws_ram_resource_share: Add arn attribute
c7d129e 
While the ARN was already present in the `id` attribute, most resources that have an ARN follow the pattern of having an `arn` attribute.

Output from acceptance testing:

```
--- PASS: TestAccAwsRamResourceShare_basic (9.85s)
--- PASS: TestAccAwsRamResourceShare_Name (15.21s)
--- PASS: TestAccAwsRamResourceShare_AllowExternalPrincipals (15.60s)
--- PASS: TestAccAwsRamResourceShare_Tags (22.71s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ram Issues and PRs that pertain to the ram service. labels Feb 21, 2019
@bflad bflad requested a review from a team February 21, 2019 14:48
@ghost ghost added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. labels Feb 21, 2019
@bflad bflad mentioned this pull request Feb 21, 2019
Closed
@bflad bflad modified the milestones: v2.2.0, v2.1.0 Feb 28, 2019
@bflad bflad merged commit 78f956d into master Mar 1, 2019
@bflad bflad deleted the f-aws_ram_resource_share-arn branch March 1, 2019 19:44
bflad added a commit that referenced this pull request Mar 1, 2019
@bflad
Update CHANGELOG for #7634
c1c90b3
@bflad
Copy link
Contributor Author

bflad commented Mar 8, 2019

This has been released in version 2.1.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad mentioned this pull request Apr 5, 2019
Closed
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ram Issues and PRs that pertain to the ram service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bflad @paddycarver