Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Optional Fields aws_s3_bucket_inventory #7952

Merged
merged 1 commit into from
Mar 17, 2019
Merged

Missing Optional Fields aws_s3_bucket_inventory #7952

merged 1 commit into from
Mar 17, 2019

Conversation

vfoucault
Copy link
Contributor

  • s3.InventoryOptionalFieldObjectLockMode,
  • s3.InventoryOptionalFieldObjectLockRetainUntilDate,
  • s3.InventoryOptionalFieldObjectLockLegalHoldStatus,

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes#7951

Changes proposed in this pull request:

  • added the three missing optional fields

s3.InventoryOptionalFieldObjectLockMode,

s3.InventoryOptionalFieldObjectLockRetainUntilDate,

s3.InventoryOptionalFieldObjectLockLegalHoldStatus,

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/s3 Issues and PRs that pertain to the s3 service. labels Mar 15, 2019
@vfoucault
Missing Optional Fields aws_s3_bucket_inventory
de060a7 
* s3.InventoryOptionalFieldObjectLockMode,
* s3.InventoryOptionalFieldObjectLockRetainUntilDate,
* s3.InventoryOptionalFieldObjectLockLegalHoldStatus,
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 17, 2019
bflad
bflad approved these changes Mar 17, 2019
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM according to all the available AWS Go SDK S3 constants for that enumeration, thanks @vfoucault! 🚀

@bflad bflad added this to the v2.3.0 milestone Mar 17, 2019
@bflad bflad merged commit c0cd0ec into hashicorp:master Mar 17, 2019
bflad added a commit that referenced this pull request Mar 17, 2019
@bflad
Update CHANGELOG for #7952
4ab79f1
@vfoucault vfoucault deleted the aws_s3_bucket_optional_fields_update branch March 18, 2019 08:12
@bflad
Copy link
Member

bflad commented Mar 21, 2019

This has been released in version 2.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vfoucault @bflad