ECR repository tag-on-create

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8195.
Tag ECR repositories on creation to prevent potential IAM permission issues.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEcrRepository_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSEcrRepository_ -timeout 120m
=== RUN   TestAccAWSEcrRepository_basic
=== PAUSE TestAccAWSEcrRepository_basic
=== RUN   TestAccAWSEcrRepository_tags
=== PAUSE TestAccAWSEcrRepository_tags
=== CONT  TestAccAWSEcrRepository_basic
=== CONT  TestAccAWSEcrRepository_tags
--- PASS: TestAccAWSEcrRepository_basic (16.62s)
--- PASS: TestAccAWSEcrRepository_tags (25.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.118s

[bflad]

LGTM, thanks @ewbankkit 🚀

Output from acceptance testing (AWS Standard):

--- PASS: TestAccAWSEcrRepository_basic (12.47s)
--- PASS: TestAccAWSEcrRepository_tags (19.46s)

Output from acceptance testing (AWS GovCloud (US)):

--- PASS: TestAccAWSEcrRepository_basic (15.37s)
--- PASS: TestAccAWSEcrRepository_tags (24.79s)

[bflad]

This has been released in version 2.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!