Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new ap-east-1 region #8437

Merged
merged 3 commits into from
Apr 25, 2019
Merged

add new ap-east-1 region #8437

merged 3 commits into from
Apr 25, 2019

Conversation

christophermichaeljohnston2
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8433

Changes proposed in this pull request:

  • adds IDs for new ap-east-1 region

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/elb Issues and PRs that pertain to the elb service. labels Apr 25, 2019
@ewbankkit
Copy link
Contributor

I think we also need the CloudTrail account ID in the aws_cloudtrail_service_account data source.

@christophermichaeljohnston2
Copy link
Author

I guess they're still updating their documentation as it wasn't there earlier. I see ap-east-1 for redshift now too.

@ghost ghost added service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/redshift Issues and PRs that pertain to the redshift service. labels Apr 25, 2019
@bflad bflad added this to the v2.8.0 milestone Apr 25, 2019
@bflad bflad added service/s3 Issues and PRs that pertain to the s3 service. enhancement Requests to existing resources that expand the functionality or scope. labels Apr 25, 2019
bflad
bflad approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, double checked the AWS documentation for each of these and they matched up. Thanks, @christophermichaeljohnston 🚀

@bflad bflad merged commit 9a79aaa into hashicorp:master Apr 25, 2019
bflad added a commit that referenced this pull request Apr 25, 2019
@bflad
Update CHANGELOG for #8437
92b3b00
@nywilken
Copy link
Member

nywilken commented Apr 27, 2019 •
edited

This has been released in version 2.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elb Issues and PRs that pertain to the elb service. service/redshift Issues and PRs that pertain to the redshift service. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.

AWS Asia Pacific (Hong Kong) Region now open
4 participants
@christophermichaeljohnston2 @ewbankkit @nywilken @bflad