Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_organizations_organization: Add non_master_accounts attribute #8926

Merged
merged 1 commit into from
Jun 18, 2019
Merged

resource/aws_organizations_organization: Add non_master_accounts attribute #8926

merged 1 commit into from
Jun 18, 2019

Conversation

bflad
Copy link
Member

@bflad bflad commented Jun 10, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8903

This seems like it might be a common use case, so we provide a native attribute rather than requiring all implementations to filter the existing accounts attribute.

Release note for CHANGELOG:

* resource/aws_organizations_organization: Add `non_master_accounts` attribute

Output from acceptance testing:

        --- PASS: TestAccAWSOrganizations/Organization/basic (14.39s)

@bflad
resource/aws_organizations_organization: Add non_master_accounts attr…
533e315 
…ibute

Reference: #8903

This seems like it might be a common use case, so we provide a native attribute rather than requiring all implementations to filter the existing `accounts` attribute.

Output from acceptance testing:

```
        --- PASS: TestAccAWSOrganizations/Organization/basic (14.39s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/organizations Issues and PRs that pertain to the organizations service. labels Jun 10, 2019
@bflad bflad requested a review from a team June 10, 2019 14:18
@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 10, 2019
@bflad bflad mentioned this pull request Jun 10, 2019
Closed
ryndaniels
ryndaniels reviewed Jun 18, 2019
View reviewed changes
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable from 👀

@bflad bflad added this to the v2.16.0 milestone Jun 18, 2019
@bflad bflad merged commit f0074f9 into master Jun 18, 2019
@bflad bflad deleted the f-aws_organizations_organization-non_master_accounts branch June 18, 2019 22:37
bflad added a commit that referenced this pull request Jun 18, 2019
@bflad
Update CHANGELOG for #8926
1b0aefc
@bflad
Copy link
Member Author

bflad commented Jun 20, 2019

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryndaniels ryndaniels ryndaniels left review comments

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/organizations Issues and PRs that pertain to the organizations service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.16.0
Development

Successfully merging this pull request may close these issues.

Update aws_organizations_organization to output accounts excluding master
2 participants
@bflad @ryndaniels