New resource: aws_autoscalingplans_scaling_plan #8965

ewbankkit · 2019-06-12T17:35:05Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

FEATURES:

* New Resource: aws_autoscalingplans_scaling_plan (#6562)

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsAutoScalingPlansScalingPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsAutoScalingPlansScalingPlan_ -timeout 120m
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_AlbAsgDynamoDbEcsDynamicScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_AlbAsgDynamoDbEcsDynamicScaling
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_CustomMetrics
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_CustomMetrics
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_AlbAsgDynamoDbEcsDynamicScaling
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_CustomMetrics
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_CustomMetrics (75.44s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling (80.35s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling (80.66s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicUpdate (108.83s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_AlbAsgDynamoDbEcsDynamicScaling (296.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	296.838s

ewbankkit · 2019-06-12T17:35:44Z

~~Currently includes the commit from #8962.~~

ewbankkit · 2019-06-12T17:40:56Z

The name aws_autoscalingplans_scaling_plan is just a straw man as the resource is implemented via a new autoscalingplans AWS API and CloudFormation names its equivalent resource similarly.
All the AWS documentation and AWS console just calls them Auto Scaling scaling plans so aws_autoscaling_scaling_plan may be the better name and also consolidate the documentation into the Autoscaling section rather than a separate section.

ewbankkit · 2019-06-18T18:02:31Z

Removing WIP.
I've actually come to be OK with the name aws_autoscalingplans_scaling_plan.

ewbankkit · 2019-07-26T18:49:10Z

Rebased to fix merge conflict.

ewbankkit · 2019-10-02T14:38:10Z

Rebased to fix merge conflict.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsAutoScalingPlansScalingPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsAutoScalingPlansScalingPlan_ -timeout 120m
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling (80.60s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling (81.03s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicUpdate (112.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	112.920s
``

ewbankkit · 2019-10-05T21:09:11Z

Rebased and did the Terraform Plugin SDK migration for the new resource.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsAutoScalingPlansScalingPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsAutoScalingPlansScalingPlan_ -timeout 120m
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling (76.66s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling (77.07s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicUpdate (104.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	104.122s

…Ec2InstanceTypeForAvailabilityZone'.

ssabo · 2020-10-07T17:24:05Z

I am not sure who to direct this question to. What is preventing this patch from being merged currently?

anGie44

Thank you for this PR @ewbankkit! Design looks great overall. It seems though the waiter methods may need some tweaking in the Pending states values as the following tests are consistently failing in Commercial and Gov Cloud:

--- FAIL: TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling (9.54s)
--- FAIL: TestAccAwsAutoScalingPlansScalingPlan_disappears (9.62s)
--- FAIL: TestAccAwsAutoScalingPlansScalingPlan_basicUpdate (9.66s)
--- FAIL: TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling (36.08s)

with the error(s):

Error: error waiting for Auto Scaling Scaling Plan (tf-acc-test-6121015609472249022/1) to be created: unexpected state 'NotFound', wanted target 'Active, ActiveWithProblems'. last error: %!s(<nil>)

Error: error waiting for Auto Scaling Scaling Plan (tf-acc-test-6406453948128485035/1) to be deleted: unexpected state 'Active', wanted target 'NotFound'. last error: %!s(<nil>)

…istency when waiting for creation and deletion. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsAutoScalingPlansScalingPlan_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAutoScalingPlansScalingPlan_ -timeout 120m === RUN TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling === PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling === RUN TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling === PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling === RUN TestAccAwsAutoScalingPlansScalingPlan_basicUpdate === PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicUpdate === RUN TestAccAwsAutoScalingPlansScalingPlan_disappears === PAUSE TestAccAwsAutoScalingPlansScalingPlan_disappears === CONT TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling === CONT TestAccAwsAutoScalingPlansScalingPlan_basicUpdate === CONT TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling === CONT TestAccAwsAutoScalingPlansScalingPlan_disappears 2020/10/16 14:29:48 [INFO] Auto Scaling Scaling Plan (tf-acc-test-2865312284272710950/1) status message: Scaling plan has been created and applied to all resources. resource_aws_autoscalingplans_scaling_plan_test.go:268: [INFO] Got non-empty plan, as expected --- PASS: TestAccAwsAutoScalingPlansScalingPlan_disappears (53.00s) --- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling (57.22s) --- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling (67.94s) --- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicUpdate (99.22s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 99.262s

ewbankkit · 2020-10-16T19:02:17Z

Modified the status codes used by the create and delete waiters to better handle eventual consistency.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsAutoScalingPlansScalingPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAutoScalingPlansScalingPlan_ -timeout 120m
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_disappears
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_disappears
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_disappears
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_disappears
    resource_aws_autoscalingplans_scaling_plan_test.go:257: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_disappears (57.76s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling (60.68s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling (61.08s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicUpdate (93.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	93.687s

website/docs/r/autoscalingplans_scaling_plan.html.markdown

Co-authored-by: angie pinilla <angelinepinilla@gmail.com>

…ith predictive scaling.

…rovider-aws into issue-6562

ewbankkit · 2020-10-19T16:58:25Z

Added testAccPreCheckIamServiceLinkedRole and used if for those acceptance tests that use predictive scaling.
Without the service-linked role:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsAutoScalingPlansScalingPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAutoScalingPlansScalingPlan_ -timeout 120m
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_disappears
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_disappears
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_disappears
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
    provider_test.go:601: skipping tests; missing IAM service-linked role /aws-service-role/autoscaling-plans. Please create the role and retry
--- SKIP: TestAccAwsAutoScalingPlansScalingPlan_basicUpdate (0.87s)
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
    provider_test.go:601: skipping tests; missing IAM service-linked role /aws-service-role/autoscaling-plans. Please create the role and retry
--- SKIP: TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling (0.98s)
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_disappears
    resource_aws_autoscalingplans_scaling_plan_test.go:263: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_disappears (35.14s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling (59.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.523s

after manually creating the service-linked role:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsAutoScalingPlansScalingPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAutoScalingPlansScalingPlan_ -timeout 120m
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== RUN   TestAccAwsAutoScalingPlansScalingPlan_disappears
=== PAUSE TestAccAwsAutoScalingPlansScalingPlan_disappears
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_disappears
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicUpdate
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling
=== CONT  TestAccAwsAutoScalingPlansScalingPlan_disappears
    resource_aws_autoscalingplans_scaling_plan_test.go:263: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_disappears (42.35s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling (56.60s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling (64.38s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicUpdate (78.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	78.746s

… issues.

aws/internal/service/autoscalingplans/finder/finder.go

Co-authored-by: angie pinilla <angelinepinilla@gmail.com>

anGie44

Looks great and acceptance tests have been corrected 👍

Output of acceptance tests (Commercial):

--- PASS: TestProvider_impl (0.12s)
--- PASS: TestProvider (1.81s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (36.00s)
--- PASS: TestAccAWSProvider_Region_AwsCommercial (36.88s)
--- PASS: TestAccAWSProvider_Region_AwsChina (37.02s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (46.29s)
--- PASS: TestAccAWSProvider_Endpoints (46.14s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (46.60s)
--- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (46.34s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (46.83s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (46.92s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (47.03s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (47.26s)
--- PASS: TestAccAWSProvider_AssumeRole_Empty (48.30s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_disappears (73.48s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling (92.06s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling (92.39s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicUpdate (117.60s)

Output of acceptance tests (Gov Cloud):

--- PASS: TestProvider_impl (0.17s)
--- PASS: TestProvider (1.17s)
--- SKIP: TestAccAwsAutoScalingPlansScalingPlan_basicPredictiveScaling (0.88s)
--- SKIP: TestAccAwsAutoScalingPlansScalingPlan_basicUpdate (0.56s)
--- PASS: TestAccAWSProvider_Region_AwsChina (34.51s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (34.30s)
--- PASS: TestAccAWSProvider_Region_AwsCommercial (35.68s)
--- PASS: TestAccAWSProvider_Endpoints (43.40s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (42.95s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (43.51s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (43.36s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (44.37s)
--- PASS: TestAccAWSProvider_AssumeRole_Empty (44.08s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (44.39s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (44.28s)
--- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (44.40s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_basicDynamicScaling (67.52s)
--- PASS: TestAccAwsAutoScalingPlansScalingPlan_disappears (71.39s)

ghost · 2020-10-22T21:38:34Z

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-11-20T17:11:09Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit force-pushed the issue-6562 branch from 583f33b to c275fd8 Compare June 12, 2019 20:16

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Jun 12, 2019

ewbankkit force-pushed the issue-6562 branch 2 times, most recently from b44b96f to 7dec826 Compare June 14, 2019 22:00

ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jun 14, 2019

ewbankkit force-pushed the issue-6562 branch 3 times, most recently from 74c3bd2 to 965799b Compare June 17, 2019 17:52

ewbankkit changed the title ~~[WIP] New resource aws_autoscalingplans_scaling_plan~~ New resource aws_autoscalingplans_scaling_plan Jun 18, 2019

bflad added new-resource Introduces a new resource. and removed dependencies Used to indicate dependency changes. labels Jun 18, 2019

aeschright requested a review from a team June 28, 2019 18:13

ewbankkit force-pushed the issue-6562 branch from 965799b to a61ecb4 Compare July 26, 2019 18:46

ewbankkit changed the title ~~New resource aws_autoscalingplans_scaling_plan~~ New resource: aws_autoscalingplans_scaling_plan Jul 31, 2019

ewbankkit force-pushed the issue-6562 branch from a61ecb4 to 28d3caf Compare October 2, 2019 14:36

ewbankkit force-pushed the issue-6562 branch from 28d3caf to 322abf5 Compare October 5, 2019 21:08

ewbankkit added 6 commits August 21, 2020 14:33

Add 'internal/service/autoscalingplans/waiter' package.

1c979ff

Simplify acceptance tests a bit.

2bddadc

r/aws_autoscalingplans_scaling_plan: Remove custom set hash functions.

dadedfe

Use 'testAccAvailableEc2InstanceTypeForRegion', not 'testAccAvailable…

22726cf

…Ec2InstanceTypeForAvailabilityZone'.

Use 'tfawsresource' acceptance test checkers.

c21359e

Upgrade to Plugin SDK v2 and use Terraform 0.12 syntax in documentation.

8304317

ewbankkit force-pushed the issue-6562 branch from 103d449 to 8304317 Compare August 21, 2020 18:33

anGie44 self-assigned this Oct 13, 2020

anGie44 suggested changes Oct 16, 2020

View reviewed changes

ewbankkit added 2 commits October 16, 2020 13:54

r/aws_autoscalingplans_scaling_plan: Use '_Values()' (hashicorp#14601).

0662a1b

Add documentation note about service-linked role.

bb43021

anGie44 reviewed Oct 19, 2020

View reviewed changes

website/docs/r/autoscalingplans_scaling_plan.html.markdown Outdated Show resolved Hide resolved

ewbankkit and others added 3 commits October 19, 2020 12:08

Update website/docs/r/autoscalingplans_scaling_plan.html.markdown

a2ab9dc

Co-authored-by: angie pinilla <angelinepinilla@gmail.com>

Add 'testAccPreCheckIamServiceLinkedRole' and use for scaling plans w…

1b8260e

…ith predictive scaling.

Merge branch 'issue-6562' of https://github.com/ewbankkit/terraform-p…

a9751f7

…rovider-aws into issue-6562

Use 'StateChangeConf.Delay' to better handle API eventual consistency…

4e83eb6

… issues.

anGie44 reviewed Oct 21, 2020

View reviewed changes

aws/internal/service/autoscalingplans/finder/finder.go Outdated Show resolved Hide resolved

Update aws/internal/service/autoscalingplans/finder/finder.go

543e5d3

Co-authored-by: angie pinilla <angelinepinilla@gmail.com>

anGie44 approved these changes Oct 21, 2020

View reviewed changes

anGie44 added this to the v3.12.0 milestone Oct 21, 2020

anGie44 merged commit 43a84a4 into hashicorp:master Oct 21, 2020

anGie44 added a commit that referenced this pull request Oct 21, 2020

Update CHANGELOG for #8965

dc85808

ewbankkit deleted the issue-6562 branch October 21, 2020 15:30

hashicorp locked as resolved and limited conversation to collaborators Nov 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: aws_autoscalingplans_scaling_plan #8965

New resource: aws_autoscalingplans_scaling_plan #8965

ewbankkit commented Jun 12, 2019 •

edited

ewbankkit commented Jun 12, 2019 •

edited

ewbankkit commented Jun 12, 2019 •

edited

ewbankkit commented Jun 18, 2019

ewbankkit commented Jul 26, 2019

ewbankkit commented Oct 2, 2019

ewbankkit commented Oct 5, 2019

ssabo commented Oct 7, 2020

anGie44 left a comment

ewbankkit commented Oct 16, 2020

ewbankkit commented Oct 19, 2020

anGie44 left a comment

ghost commented Oct 22, 2020

ghost commented Nov 20, 2020

New resource: aws_autoscalingplans_scaling_plan #8965

New resource: aws_autoscalingplans_scaling_plan #8965

Conversation

ewbankkit commented Jun 12, 2019 • edited

Community Note

ewbankkit commented Jun 12, 2019 • edited

ewbankkit commented Jun 12, 2019 • edited

ewbankkit commented Jun 18, 2019

ewbankkit commented Jul 26, 2019

ewbankkit commented Oct 2, 2019

ewbankkit commented Oct 5, 2019

ssabo commented Oct 7, 2020

anGie44 left a comment

Choose a reason for hiding this comment

ewbankkit commented Oct 16, 2020

ewbankkit commented Oct 19, 2020

anGie44 left a comment

Choose a reason for hiding this comment

ghost commented Oct 22, 2020

ghost commented Nov 20, 2020

ewbankkit commented Jun 12, 2019 •

edited

ewbankkit commented Jun 12, 2019 •

edited

ewbankkit commented Jun 12, 2019 •

edited