Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra retry and cleanup errors for deleting api gateway resource #9054

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Related #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_api_gateway_resource: Removes an extraneous retry when deleting API gateway resource

Output from acceptance testing:

make testacc TESTARGS="-run=TestAccAWSAPIGatewayResource"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAPIGatewayResource -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAPIGatewayResource_basic
=== PAUSE TestAccAWSAPIGatewayResource_basic
=== RUN   TestAccAWSAPIGatewayResource_update
=== PAUSE TestAccAWSAPIGatewayResource_update
=== CONT  TestAccAWSAPIGatewayResource_basic
=== CONT  TestAccAWSAPIGatewayResource_update
--- PASS: TestAccAWSAPIGatewayResource_basic (30.35s)
--- PASS: TestAccAWSAPIGatewayResource_update (62.21s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       63.059s

@ryndaniels ryndaniels requested a review from bflad June 19, 2019 16:24
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Jun 19, 2019
@bflad bflad added the service/apigateway Issues and PRs that pertain to the apigateway service. label Jun 20, 2019
@bflad bflad self-assigned this Jun 20, 2019
@bflad bflad added this to the v2.16.0 milestone Jun 20, 2019
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one bites the dust! LGTM 🚀

--- PASS: TestAccAWSAPIGatewayResource_basic (8.28s)
--- PASS: TestAccAWSAPIGatewayResource_update (65.99s)

@bflad bflad assigned ryndaniels and unassigned bflad Jun 20, 2019
@ryndaniels ryndaniels merged commit 1242302 into master Jun 20, 2019
@ryndaniels ryndaniels deleted the rfd-retry-apigateway branch June 20, 2019 11:53
@bflad
Copy link
Member

bflad commented Jun 20, 2019

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants