Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Automatically configure AWS China Route 53 region and endpoint #9060

Merged
merged 1 commit into from
Jun 20, 2019
Merged

provider: Automatically configure AWS China Route 53 region and endpoint #9060

merged 1 commit into from
Jun 20, 2019

Conversation

bflad
Copy link
Member

@bflad bflad commented Jun 19, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9052

Release note for CHANGELOG:

* provider: Properly configure Route 53 service client in AWS China

Output from acceptance testing: N/A this is a best effort fix for AWS China Route 53 support as the maintainers do not have access to AWS China.

@bflad bflad added bug Addresses a defect in current functionality. service/route53 Issues and PRs that pertain to the route53 service. partition/aws-cn Pertains to the aws-cn partition. labels Jun 19, 2019
@bflad bflad requested a review from a team June 19, 2019 20:13
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jun 19, 2019
@bflad bflad mentioned this pull request Jun 19, 2019
Closed
nywilken
nywilken approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@nywilken nywilken added this to the v2.16.0 milestone Jun 20, 2019
@bflad bflad merged commit ace022d into master Jun 20, 2019
@bflad bflad deleted the b-route53-china branch June 20, 2019 03:30
bflad added a commit that referenced this pull request Jun 20, 2019
@bflad
Update CHANGELOG for #9060
dd57f1b
@bflad
Copy link
Member Author

bflad commented Jun 20, 2019

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. partition/aws-cn Pertains to the aws-cn partition. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.16.0
Development

Successfully merging this pull request may close these issues.

Route53 failed to specify region
2 participants
@bflad @nywilken