Add support for lambda permission import

[chaspy]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #9357

Release note for CHANGELOG:

resource/aws_lambda_permission: Support resource import

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_basic' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchEventTarget_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchEventTarget_basic
=== PAUSE TestAccAWSCloudWatchEventTarget_basic
=== CONT  TestAccAWSCloudWatchEventTarget_basic
--- PASS: TestAccAWSCloudWatchEventTarget_basic (58.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	58.721s

[chaspy]

@ryndaniels Please review 🙏

[ryndaniels]

Hi @chaspy 👋 Thanks for this contribution! Overall this looks good - there's just a couple changes we'd like to see in the tests and the docs, so if you're able to make those and re-run the acceptance tests on your end, we can keep moving forward with this. Thanks! 😄

[chaspy]

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchEventTarget_basic -timeout 120m

=== RUN   TestAccAWSCloudWatchEventTarget_basic
=== PAUSE TestAccAWSCloudWatchEventTarget_basic
=== CONT  TestAccAWSCloudWatchEventTarget_basic
--- PASS: TestAccAWSCloudWatchEventTarget_basic (67.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	67.690s

$ make testacc TESTARGS='-run=TestAccAWSLambdaPermission_withRawFunctionName' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSLambdaPermission_withRawFunctionName -timeout 120m

=== RUN   TestAccAWSLambdaPermission_withRawFunctionName
=== PAUSE TestAccAWSLambdaPermission_withRawFunctionName
=== CONT  TestAccAWSLambdaPermission_withRawFunctionName
--- FAIL: TestAccAWSLambdaPermission_withRawFunctionName (112.13s)
    testing.go:568: Step 1 error: Cannot import non-existent remote object: While attempting to import an existing object to aws_lambda_permission.allow_cloudwatch, the provider detected that no object exists with the given id. Only pre-existing objects can be imported; check that the id is correct and that it is associated with the provider's configured region or endpoint, or use "terraform apply" to create a new remote object for this resource.
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	112.194s

😥

[ryndaniels]

Hi @chaspy! Thanks for the quick turnaround on those changes! I took a look at the new test failures you were seeing and I think I've found what's going on. It looks like there's a few mismatches in statementId and ResourceName in the different test blocks that are causing the failures we're seeing.

One way that we could simplify the tests and fix those would be to create a ImportStateIdFunc function, the same way you did in #9431. I was working on testing that out locally, and realized that we'll need a bit more logic to handle TestAccAWSLambdaPermission_withQualifier and TestAccAWSLambdaPermission_withStatementIdPrefix correctly. I'm going to go ahead and continue working on getting those finished, and I'll keep this PR updated as I do. 🙂

[ryndaniels]

Latest acceptance test output:

--- PASS: TestLambdaPermissionGetFunctionNameFromLambdaArn_valid (0.00s)
--- PASS: TestLambdaPermissionUnmarshalling (0.00s)
--- PASS: TestLambdaPermissionGetQualifierFromLambdaAliasOrVersionArn_invalid (0.00s)
--- PASS: TestLambdaPermissionGetFunctionNameFromLambdaArn_invalid (0.00s)
--- PASS: TestLambdaPermissionGetQualifierFromLambdaAliasOrVersionArn_alias (0.00s)
--- PASS: TestLambdaPermissionGetQualifierFromLambdaAliasOrVersionArn_version (0.00s)
--- PASS: TestLambdaPermissionGetQualifierFromLambdaAliasOrVersionArn_govcloud (0.00s)
--- PASS: TestLambdaPermissionGetFunctionNameFromGovCloudLambdaArn (0.00s)
--- PASS: TestAccAWSLambdaPermission_withS3 (27.53s)
--- PASS: TestAccAWSLambdaPermission_withIAMRole (27.65s)
--- PASS: TestAccAWSLambdaPermission_withQualifier (27.97s)
--- PASS: TestAccAWSLambdaPermission_withRawFunctionName (28.06s)
--- PASS: TestAccAWSLambdaPermission_basic (27.91s)
--- PASS: TestAccAWSLambdaPermission_withStatementIdPrefix (28.22s)
--- PASS: TestAccAWSLambdaPermission_withSNS (28.23s)
--- PASS: TestAccAWSLambdaPermission_multiplePerms (34.30s)
--- PASS: TestAccAWSLambdaPermission_StatementId_Duplicate (83.63s)

[bflad]

LGTM once the suggested changes are made and the testing passes 👍

[ghost]

This has been released in version 2.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!