Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes website_endpoint and website_domain attributes in Chinese regions #9444

Merged
merged 4 commits into from
Jul 24, 2019
Merged

Fixes website_endpoint and website_domain attributes in Chinese regions #9444

merged 4 commits into from
Jul 24, 2019

Conversation

antonio-osorio
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #9378

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_s3_bucket: Fixes website_endpoint and website_domain attribute for Chinese regions

@antonio-osorio antonio-osorio requested a review from a team July 23, 2019 00:16
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 23, 2019
@antonio-osorio
Copy link
Author 

go test ./... -timeout=30s -parallel=4
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
# github.com/terraform-providers/terraform-provider-aws/aws [github.com/terraform-providers/terraform-provider-aws/aws.test]
fatal error: runtime: cannot allocate memory

@bflad bflad added bug Addresses a defect in current functionality. partition/aws-cn Pertains to the aws-cn partition. labels Jul 23, 2019
@bflad bflad mentioned this pull request Jul 23, 2019
Closed
bflad
bflad suggested changes Jul 23, 2019
View reviewed changes
aws/resource_aws_s3_bucket.go Outdated Show resolved Hide resolved
@bflad bflad self-assigned this Jul 23, 2019
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jul 23, 2019
@antonio-osorio
Copy link
Author

@bflad Updated the PR to incorporate your changes.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 23, 2019
@bflad bflad added this to the v2.21.0 milestone Jul 24, 2019
bflad
bflad approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, @antonio-osorio 🚀

@bflad bflad merged commit 200e193 into hashicorp:master Jul 24, 2019
bflad added a commit that referenced this pull request Jul 24, 2019
@bflad
Update CHANGELOG for #9444
6931798
@antonio-osorio antonio-osorio deleted the fix_china_website_endpoint_url branch July 25, 2019 22:35
@bflad
Copy link
Member

bflad commented Jul 26, 2019

This has been released in version 2.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests, documentation updates, or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ewbankkit ewbankkit mentioned this pull request Aug 2, 2019
Closed
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. partition/aws-cn Pertains to the aws-cn partition. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.21.0
Development

Successfully merging this pull request may close these issues.

Wrong S3 bucket website_endpoint and website_domain attributes in China regions
2 participants
@antonio-osorio @bflad