Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data/aws_lambda_alias: new data source #9490

Merged
merged 3 commits into from
Feb 20, 2020
Merged

data/aws_lambda_alias: new data source #9490

merged 3 commits into from
Feb 20, 2020

Conversation

nlee737
Copy link
Contributor

@nlee737 nlee737 commented Jul 24, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #8938

Release note for CHANGELOG:

* New Data Source: * `aws_lambda_alias`

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaAlias_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSLambdaAlias_basic -timeout 120m
=== RUN   TestAccAWSLambdaAlias_basic
=== PAUSE TestAccAWSLambdaAlias_basic
=== CONT  TestAccAWSLambdaAlias_basic
--- PASS: TestAccAWSLambdaAlias_basic (22.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	22.236s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/lambda Issues and PRs that pertain to the lambda service. labels Jul 24, 2019
@nlee737 nlee737 changed the title data/aws_lambda_alias: new data source [wip] data/aws_lambda_alias: new data source Jul 24, 2019
@ghost ghost added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 27, 2019
@nlee737 nlee737 marked this pull request as ready for review July 27, 2019 16:08
@nlee737 nlee737 requested a review from a team July 27, 2019 16:08
@nlee737 nlee737 changed the title [wip] data/aws_lambda_alias: new data source data/aws_lambda_alias: new data source Jul 27, 2019
@bflad bflad added the new-data-source Introduces a new data source. label Jul 31, 2019
@bflad bflad added this to the v2.50.0 milestone Feb 20, 2020
@bflad bflad self-assigned this Feb 20, 2020
bflad
bflad approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this submission, @mnkyl, and apologies for the delayed review. Overall this was well implemented and just needed some modernization due to AWS and Terraform AWS Provider development changes that have happened since submission, which were handled during merge.

Output from acceptance testing:

--- PASS: TestAccDataSourceAWSLambdaAlias_basic (43.98s)

aws/data_source_aws_lambda_alias.go
Required: true,
},

"alias_name": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the Lambda API refers to this as Name and the aws_lambda_alias resource uses a name argument, we will change this attribute to match. 👍

aws/data_source_aws_lambda_alias.go

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/lambda"
"github.com/hashicorp/terraform/helper/schema"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was submitted, there has been a few changes to Terraform AWS Provider development, including the import path for the Terraform Plugin SDK. This will be handled on merge along with a few other modernization changes that are required (NodeJS 8 deprecation in testing, etc).

@bflad bflad merged commit 7ca8247 into hashicorp:master Feb 20, 2020
bflad added a commit that referenced this pull request Feb 20, 2020
@bflad
Update CHANGELOG for #9490
24f30d4
@ghost
Copy link

ghost commented Feb 21, 2020

This has been released in version 2.50.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/lambda Issues and PRs that pertain to the lambda service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.50.0
Development

Successfully merging this pull request may close these issues.

aws_lambda_alias data source
2 participants
@nlee737 @bflad