Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_rds_cluster: Add multimaster to engine_mode validation #9691

Merged
merged 1 commit into from
Aug 9, 2019
Merged

resource/aws_rds_cluster: Add multimaster to engine_mode validation #9691

merged 1 commit into from
Aug 9, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 8, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9690

Release note for CHANGELOG:

* resource/aws_rds_cluster: Add `multimaster` to `engine_mode` argument validation (support Aurora Multi-Master Clusters)

Output from acceptance testing:

--- PASS: TestAccAWSRDSCluster_EngineMode_Multimaster (141.13s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. labels Aug 8, 2019
@bflad bflad requested a review from a team August 8, 2019 23:20
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 8, 2019
@bflad bflad mentioned this pull request Aug 8, 2019
Closed
@bflad
resource/aws_rds_cluster: Add multimaster to engine_mode validation
0612479 
Reference: #9690

Output from acceptance testing:

```
--- PASS: TestAccAWSRDSCluster_EngineMode_Multimaster (141.13s)
```
@bflad bflad force-pushed the f-aws_rds_cluster-multimaster branch from 5b267d5 to 0612479 Compare August 9, 2019 02:11
@ryndaniels ryndaniels self-assigned this Aug 9, 2019
ryndaniels
ryndaniels approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

PASS: TestAccAWSRDSCluster_EngineMode_Multimaster (113.50s)

@bflad bflad added this to the v2.24.0 milestone Aug 9, 2019
@bflad bflad merged commit c16a267 into master Aug 9, 2019
@bflad bflad deleted the f-aws_rds_cluster-multimaster branch August 9, 2019 14:41
bflad added a commit that referenced this pull request Aug 9, 2019
@bflad
Update CHANGELOG for #9691
21c99dd
@ghost
Copy link

ghost commented Aug 15, 2019

This has been released in version 2.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryndaniels ryndaniels ryndaniels approved these changes

Assignees

@ryndaniels ryndaniels

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.24.0
Development

Successfully merging this pull request may close these issues.

Support for Aurora Multi-Master Clusters
2 participants
@bflad @ryndaniels