Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #9831 Add support for source version to aws_codebuild_project resource Closes #9831 #9877

Merged
merged 5 commits into from Feb 3, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2019

Added basic support for source_version to aws_codebuild_resource. The documentation states you can declare this at the "build" level which will take precedence over the "project" level, but for now I only added support at the "project" level.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ghost ghost self-requested a review August 26, 2019 02:14
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/codebuild Issues and PRs that pertain to the codebuild service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 26, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 29, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ra999 👋 Thank you for submitting this. Overall it looks pretty good, just two minor fixes so we can get this in. If you change the PR description to include Closes #9831, GitHub will automatically associate the PR to close the issue as well. Please reach out if you have any questions or do not have time to implement the feedback. 👍

aws/resource_aws_codebuild_project_test.go Outdated Show resolved Hide resolved
website/docs/r/codebuild_project.html.markdown Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jan 29, 2020
@bflad bflad self-assigned this Jan 29, 2020
@ghost ghost changed the title Issue #9831 Add support for source version to aws_codebuild_project resource Issue #9831 Add support for source version to aws_codebuild_project resource Closes #9831 Feb 3, 2020
RA999 and others added 3 commits February 2, 2020 22:07
Co-Authored-By: Brian Flad <bflad417@gmail.com>
Co-Authored-By: Brian Flad <bflad417@gmail.com>
@ghost
Copy link
Author

ghost commented Feb 3, 2020

All checks have passed and I have updated code according to comments

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Feb 3, 2020
@bflad bflad added this to the v2.48.0 milestone Feb 3, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for those updates, @ra999 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCodeBuildProject_ARMContainer (40.29s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (60.84s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (44.89s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Location (124.91s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Name (56.22s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (78.33s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (73.42s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (108.14s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (59.50s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Type (93.20s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (61.42s)
--- PASS: TestAccAWSCodeBuildProject_basic (86.71s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (117.90s)
--- PASS: TestAccAWSCodeBuildProject_Cache (195.22s)
--- PASS: TestAccAWSCodeBuildProject_Description (104.13s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (102.56s)
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (110.81s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (104.94s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (54.99s)
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (43.43s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (54.45s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (72.65s)
--- PASS: TestAccAWSCodeBuildProject_QueuedTimeout (228.88s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (37.95s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier (116.86s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled (48.82s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Location (39.87s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType (44.27s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName (44.98s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging (53.86s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Path (45.85s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Type (60.28s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (52.21s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig (139.64s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (148.52s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig (244.66s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (54.24s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (50.83s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (109.46s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (56.39s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (58.04s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (57.47s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (70.22s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (226.82s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (55.64s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (11.85s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (154.26s)
--- PASS: TestAccAWSCodeBuildProject_SourceVersion (65.42s)
--- PASS: TestAccAWSCodeBuildProject_Tags (151.58s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (84.78s)
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (40.38s)

@bflad bflad merged commit 797f77a into hashicorp:master Feb 3, 2020
bflad added a commit that referenced this pull request Feb 3, 2020
@ghost
Copy link

ghost commented Feb 7, 2020

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

bflad added a commit that referenced this pull request Feb 10, 2020
@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant