fix(diffDynamoDbGSI): ignore ordering of non_key_attributes in equali…

[shalka]

…ty check to stop forced reconstruction of GSI [fixes ##3828]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[cakejelly]

Would love to see this merged. Is there any update?

[twnbay78]

Can we please get this reviewed and merged? We are employing some not-so-pretty workarounds for this currently.

[anGie44]

Hi @shalka 👋 Thanks so much for this PR! It's off to a great start 👍 Just a couple moments around the use of a Set when calling the non_key_attributes from the resource data. Please let me know if you have any additional questions or concerns regarding the changes.

Output of acceptance tests

--- FAIL: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (102.32s) <-- should be fixed up 
with the proposed changes as the update isn't taking place as expected in this test where the # of 
non_key_attributes increases from 1 to 2

--- PASS: TestDiffDynamoDbGSI (0.04s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (14.35s)
--- PASS: TestAccAWSDynamoDbTable_disappears (47.99s)
--- PASS: TestAccAWSDynamoDbTableItem_rangeKey (53.26s)
--- PASS: TestAccAWSDynamoDbTableItem_withMultipleItems (57.53s)
--- PASS: TestAccAWSDynamoDbTableItem_basic (60.85s)
--- PASS: TestAccAWSDynamoDbTable_basic (66.47s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Enabled (61.32s)
--- PASS: TestAccAWSDynamoDbTable_tags (80.00s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (23.55s)
--- PASS: TestAccAWSDynamoDbTableItem_updateWithRangeKey (97.82s)
--- PASS: TestAccAWSDynamoDbTableItem_update (98.31s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned (101.90s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (105.52s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned (110.05s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (112.09s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (115.27s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Disabled (68.40s)
--- PASS: TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI (120.43s)
--- PASS: TestAccAWSDynamoDbTable_encryption (149.06s)
--- PASS: TestAccAWSDynamoDbTable_extended (294.61s)
--- PASS: TestAccAWSDynamoDbTable_Replica_Single (368.92s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (550.45s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (604.70s)
--- PASS: TestAccAWSDynamoDbTable_Replica_Multiple (736.12s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest (1339.53s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest (1359.85s)

[anGie44]

Hi @shalka 👋 thanks again for this PR! Just dropping a note that I'll be continuing the work here, as our general response time from community PRs is 2 weeks, and hope to get these changes into an upcoming release of the provider :) if you have any questions, please let me know!

[anGie44]

Output of acceptance tests:

--- PASS: TestDiffDynamoDbGSI (0.00s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (16.11s)
--- PASS: TestAccAWSDynamoDbTable_disappears (49.66s)
--- PASS: TestAccAWSDynamoDbTableItem_basic (57.19s)
--- PASS: TestAccAWSDynamoDbTableItem_rangeKey (59.28s)
--- PASS: TestAccAWSDynamoDbTableItem_withMultipleItems (62.66s)
--- PASS: TestAccAWSDynamoDbTable_basic (71.37s)
--- PASS: TestAccAWSDynamoDbTable_tags (83.63s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (25.00s)
--- PASS: TestAccAWSDynamoDbTableItem_updateWithRangeKey (97.73s)
--- PASS: TestAccAWSDynamoDbTableItem_update (101.41s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (113.76s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Enabled (63.72s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned (114.79s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes_emptyPlan (102.05s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (120.00s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (121.57s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned (124.68s)
--- PASS: TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI (129.02s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Disabled (73.88s)
--- PASS: TestAccAWSDynamoDbTable_encryption (140.50s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (303.51s)
--- PASS: TestAccAWSDynamoDbTable_extended (310.73s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (579.53s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (644.06s)
--- PASS: TestAccAWSDynamoDbTable_Replica_Single (564.01s)
--- PASS: TestAccAWSDynamoDbTable_Replica_Multiple (949.75s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest (1046.09s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest (1049.24s)

[bflad]

This should certainly improve the situation. 🚀

[ghost]

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!