d/aws_ami: Refactor tagging logic to keyvaluetags package

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAmiDataSource_'
=== RUN   TestAccAWSAmiDataSource_natInstance
=== PAUSE TestAccAWSAmiDataSource_natInstance
=== CONT  TestAccAWSAmiDataSource_natInstance
--- PASS: TestAccAWSAmiDataSource_natInstance (48.53s)
=== RUN   TestAccAWSAmiDataSource_windowsInstance
=== PAUSE TestAccAWSAmiDataSource_windowsInstance
=== CONT  TestAccAWSAmiDataSource_windowsInstance
--- PASS: TestAccAWSAmiDataSource_windowsInstance (70.44s)
=== RUN   TestAccAWSAmiDataSource_instanceStore
=== PAUSE TestAccAWSAmiDataSource_instanceStore
=== CONT  TestAccAWSAmiDataSource_instanceStore
--- PASS: TestAccAWSAmiDataSource_instanceStore (46.50s)
=== RUN   TestAccAWSAmiDataSource_localNameFilter
=== PAUSE TestAccAWSAmiDataSource_localNameFilter
=== CONT  TestAccAWSAmiDataSource_localNameFilter
--- PASS: TestAccAWSAmiDataSource_localNameFilter (58.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	93.250s

...

there aren't really test cases for amis with tags for this PR, but on the other hand there weren't before as either.

[bflad]

LGTM, thanks @DrFaust92 🚀

--- PASS: TestAccAWSAmiDataSource_instanceStore (9.06s)
--- PASS: TestAccAWSAmiDataSource_natInstance (10.99s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (13.90s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (18.33s)

[ghost]

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!