Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_route53_resolver_query_log_config: New resource #14897

Merged
merged 4 commits into from
Sep 21, 2020
Merged

r/aws_route53_resolver_query_log_config: New resource #14897

merged 4 commits into from
Sep 21, 2020

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #14877

Release note for CHANGELOG:

New resource `aws_route53_resolver_query_log_config`.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute53ResolverQueryLogConfig_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverQueryLogConfig_ -timeout 120m
=== RUN   TestAccAWSRoute53ResolverQueryLogConfig_basic
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfig_basic
=== RUN   TestAccAWSRoute53ResolverQueryLogConfig_disappears
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfig_disappears
=== RUN   TestAccAWSRoute53ResolverQueryLogConfig_tags
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfig_tags
=== CONT  TestAccAWSRoute53ResolverQueryLogConfig_basic
=== CONT  TestAccAWSRoute53ResolverQueryLogConfig_tags
=== CONT  TestAccAWSRoute53ResolverQueryLogConfig_disappears
    resource_aws_route53_resolver_query_log_config_test.go:102: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute53ResolverQueryLogConfig_basic (33.82s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfig_disappears (34.18s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfig_tags (52.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	52.900s
$ TEST=./aws SWEEP=us-west-2,us-east-1 SWEEPARGS=-sweep-run=aws_route53_resolver_query_log_config make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./aws -v -sweep=us-west-2,us-east-1 -sweep-run=aws_route53_resolver_query_log_config -timeout 60m
2020/08/28 15:24:17 [DEBUG] Running Sweepers for region (us-west-2):
2020/08/28 15:24:17 [DEBUG] Running Sweeper (aws_route53_resolver_query_log_config) in region (us-west-2)
2020/08/28 15:24:17 [INFO] AWS Auth provider used: "EnvProvider"
2020/08/28 15:24:17 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/08/28 15:24:18 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/08/28 15:24:19 [INFO] Deleting Route53 Resolver Query Log Config: rqlc-1b33aab839f54bfb
2020/08/28 15:24:19 [DEBUG] Deleting Route53 Resolver Query Log Config (rqlc-1b33aab839f54bfb)
2020/08/28 15:24:19 [DEBUG] Waiting for state to become: []
2020/08/28 15:24:20 Sweeper Tests ran successfully:
	- aws_route53_resolver_query_log_config
2020/08/28 15:24:20 [DEBUG] Running Sweepers for region (us-east-1):
2020/08/28 15:24:20 [DEBUG] Running Sweeper (aws_route53_resolver_query_log_config) in region (us-east-1)
2020/08/28 15:24:20 [INFO] AWS Auth provider used: "EnvProvider"
2020/08/28 15:24:20 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/08/28 15:24:20 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/08/28 15:24:20 Sweeper Tests ran successfully:
	- aws_route53_resolver_query_log_config
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.807s

@ewbankkit ewbankkit requested a review from a team August 28, 2020 19:32
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Aug 28, 2020
@ewbankkit ewbankkit mentioned this pull request Aug 28, 2020
Closed
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. labels Aug 28, 2020
@ewbankkit ewbankkit mentioned this pull request Aug 28, 2020
Merged
DrFaust92
DrFaust92 approved these changes Aug 30, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSRoute53ResolverQueryLogConfig_disappears (79.40s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfig_tags (148.21s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfig_basic (116.71s)

@ewbankkit ewbankkit force-pushed the f-aws_route53_resolver_query_log_config-resource branch from 38ffaa3 to 189c3ac Compare September 2, 2020 18:13
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @ewbankkit!

Verified Acceptance Tests (Commercial)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute53ResolverQueryLogConfig_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverQueryLogConfig_ -timeout 120m
=== RUN   TestAccAWSRoute53ResolverQueryLogConfig_basic
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfig_basic
=== RUN   TestAccAWSRoute53ResolverQueryLogConfig_disappears
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfig_disappears
=== RUN   TestAccAWSRoute53ResolverQueryLogConfig_tags
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfig_tags
=== CONT  TestAccAWSRoute53ResolverQueryLogConfig_basic
=== CONT  TestAccAWSRoute53ResolverQueryLogConfig_tags
=== CONT  TestAccAWSRoute53ResolverQueryLogConfig_disappears
    resource_aws_route53_resolver_query_log_config_test.go:102: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute53ResolverQueryLogConfig_disappears (25.74s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfig_basic (30.99s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfig_tags (50.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.307s

TEST=./aws SWEEP=us-west-2,us-east-1 SWEEPARGS=-sweep-run=aws_route53_resolver_query_log_config make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./aws -v -sweep=us-west-2,us-east-1 -sweep-run=aws_route53_resolver_query_log_config -timeout 60m
2020/09/21 08:28:33 [DEBUG] Running Sweepers for region (us-west-2):
2020/09/21 08:28:33 [DEBUG] Running Sweeper (aws_route53_resolver_query_log_config) in region (us-west-2)
2020/09/21 08:28:33 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2020/09/21 08:28:33 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/09/21 08:28:34 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/09/21 08:28:35 Sweeper Tests ran successfully:
	- aws_route53_resolver_query_log_config
2020/09/21 08:28:35 [DEBUG] Running Sweepers for region (us-east-1):
2020/09/21 08:28:35 [DEBUG] Running Sweeper (aws_route53_resolver_query_log_config) in region (us-east-1)
2020/09/21 08:28:35 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2020/09/21 08:28:35 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/09/21 08:28:35 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/09/21 08:28:37 Sweeper Tests ran successfully:
	- aws_route53_resolver_query_log_config
ok  	github.com/terraform-providers/terraform-provider-aws/aws	5.821s

Verified Acceptance Tests (GovCloud)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute53ResolverQueryLogConfig_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverQueryLogConfig_ -timeout 120m
=== RUN   TestAccAWSRoute53ResolverQueryLogConfig_basic
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfig_basic
=== RUN   TestAccAWSRoute53ResolverQueryLogConfig_disappears
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfig_disappears
=== RUN   TestAccAWSRoute53ResolverQueryLogConfig_tags
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfig_tags
=== CONT  TestAccAWSRoute53ResolverQueryLogConfig_basic
=== CONT  TestAccAWSRoute53ResolverQueryLogConfig_tags
=== CONT  TestAccAWSRoute53ResolverQueryLogConfig_disappears
    resource_aws_route53_resolver_query_log_config_test.go:102: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute53ResolverQueryLogConfig_disappears (16.53s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfig_basic (19.41s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfig_tags (32.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	34.749s

TEST=./aws SWEEP=us-gov-west-1 SWEEPARGS=-sweep-run=aws_route53_resolver_query_log_config make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./aws -v -sweep=us-gov-west-1 -sweep-run=aws_route53_resolver_query_log_config -timeout 60m
2020/09/21 08:36:41 [DEBUG] Running Sweepers for region (us-gov-west-1):
2020/09/21 08:36:41 [DEBUG] Running Sweeper (aws_route53_resolver_query_log_config) in region (us-gov-west-1)
2020/09/21 08:36:41 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2020/09/21 08:36:42 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/09/21 08:36:42 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/09/21 08:36:44 Sweeper Tests ran successfully:
	- aws_route53_resolver_query_log_config
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.910s

@breathingdust breathingdust added this to the v3.8.0 milestone Sep 21, 2020
@breathingdust breathingdust merged commit faa2014 into hashicorp:master Sep 21, 2020
breathingdust added a commit that referenced this pull request Sep 21, 2020
@breathingdust
Update CHANGELOG for #14897
a0470ce
@ewbankkit ewbankkit deleted the f-aws_route53_resolver_query_log_config-resource branch September 21, 2020 16:06
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrFaust92 DrFaust92 DrFaust92 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ewbankkit @breathingdust @DrFaust92