resource/aws_security_group: Set SchemaConfigModeAttr on egress and ingress configuration block attributes #8187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngress configuration block attributes References: * hashicorp/terraform#20505 * hashicorp/terraform#20626 In Terraform 0.12, behaviors with configuration blocks are more explicit to allow configuration language improvements and remove ambiguities that required various undocumented workarounds in Terraform 0.11 and prior. As a consequence, configuration blocks that are marked `Optional: true` and `Computed: true` will no longer support explicitly zero-ing out the configuration without special implementation. The `ConfigMode` schema parameter on the configuration block attribute allows the schema to override certain behaviors. In particular, setting `ConfigMode: schema.SchemaConfigModeAttr` will allow practitioners to continue setting the configuration block attribute to an empty list (in the semantic sense, e.g. `attr = []`), keeping this prior behavior in Terraform 0.12. This parameter does not have any effect with Terraform 0.11. This solution may be temporary or revisited in the future. Previous output from Terraform 0.11: ``` --- PASS: TestAccAWSSecurityGroup_Egress_ConfigMode (50.28s) --- PASS: TestAccAWSSecurityGroup_Ingress_ConfigMode (49.85s) ``` Previous output from Terraform 0.12: ``` --- FAIL: TestAccAWSSecurityGroup_Egress_ConfigMode (31.74s) testing.go:568: Step 2 error: config is invalid: Unsupported argument: An argument named "egress" is not expected here. Did you mean to define a block of type "egress"? --- FAIL: TestAccAWSSecurityGroup_Ingress_ConfigMode (31.94s) testing.go:568: Step 2 error: config is invalid: Unsupported argument: An argument named "ingress" is not expected here. Did you mean to define a block of type "ingress"? ``` Output from Terraform 0.11: ``` --- PASS: TestAccAWSSecurityGroup_Egress_ConfigMode (52.27s) --- PASS: TestAccAWSSecurityGroup_Ingress_ConfigMode (53.55s) ``` Output from Terraform 0.12: ``` --- PASS: TestAccAWSSecurityGroup_Egress_ConfigMode (57.20s) --- PASS: TestAccAWSSecurityGroup_Ingress_ConfigMode (55.80s) ```
bflad
added
service/ec2
ghost
added
size/L
…tributes as blocks documentation
minamijoyo
added a commit
to minamijoyo/tfschema
that referenced
this pull request
May 21, 2019
Fixes #9 Terraform v0.12 introduced a new `SchemaConfigModeAttr` feature. Most attributes have simple types, but if `SchemaConfigModeAttr` is set for an attribute, it is syntactically NestedBlock but semantically interpreted as an Attribute. In this case, Attribute has a complex data type. It is reasonable to use the same notation as the type annotation in HCL2 to represent the correct data type. However, it seems that HCL2 has a type annotation parser but no writer, so we implement it by ourselves. See also: - #9 - hashicorp/terraform-provider-aws#8187 - hashicorp/terraform#20626 - https://www.terraform.io/docs/configuration/types.html This is a breaking change caused by the upstream, so I think it is impossible to maintain tfschema backward compatibility. I tried to be as consistent as possible.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
References:
In Terraform 0.12, behaviors with configuration blocks are more explicit to allow configuration language improvements and remove ambiguities that required various undocumented workarounds in Terraform 0.11 and prior. As a consequence, configuration blocks that are marked
Optional: trueandComputed: truewill no longer support explicitly zero-ing out the configuration without special implementation.The
ConfigModeschema parameter on the configuration block attribute allows the schema to override certain behaviors. In particular, settingConfigMode: schema.SchemaConfigModeAttrwill allow practitioners to continue setting the configuration block attribute to an empty list (in the semantic sense, e.g.attr = []), keeping this prior behavior in Terraform 0.12. This parameter does not have any effect with Terraform 0.11. This solution may be temporary or revisited in the future.Previous output from Terraform 0.11:
Previous output from Terraform 0.12:
Output from Terraform 0.11:
Output from Terraform 0.12: