Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for dynamodb autoscaling policy import #8397

Merged
merged 8 commits into from
Jul 18, 2019
+103 −18
Merged

fix for dynamodb autoscaling policy import #8397

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6f4e59b
fix to fix dynamodb autoscaling policy import and also keep ecs and r…
jdecarli Apr 21, 2019
8e280ed
refactor/cleanup and unit test for validateAppautoscalingPolicyImport…
jdecarli Apr 23, 2019
ca98ae3
updating to use the same table names as the documentation
jdecarli Apr 23, 2019
c4f2e1e
refactor and cleanup resourceAwsAppautoscalingPolicyImport
jdecarli May 21, 2019
b0e095c
fixing typo/error in test logic
jdecarli May 22, 2019
7d86d43
fixing integration test (TestAccAWSAppautoScalingPolicy_dynamoDb)
jdecarli May 24, 2019
7ecc6c1
resource/aws_appautoscaling_policy: Update import validation support
nywilken Jul 18, 2019
a04400e
Merge branch 'master' into fix-for-dynamodb-policy-import-issue-8306
nywilken Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions aws/resource_aws_appautoscaling_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,15 +407,13 @@ func resourceAwsAppautoscalingPolicyDelete(d *schema.ResourceData, meta interfac

func resourceAwsAppautoscalingPolicyImport(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) {
idParts := strings.Split(d.Id(), "/")
var serviceNamespace, resourceId, scalableDimension, policyName string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about moving all this string splitting logic into validateAppautoscalingPolicyImportInput to help simplify the Import function?

  func resourceAwsAppautoscalingPolicyImport(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) {                          
    idParts, err := validateAppautoscalingPolicyImportInput(d.Id())                                                                               
    if err != nil {                                                                                                                               
      return nil, fmt.Errorf("unexpected format (%q), expected <service-namespace>/<resource-id>/<scalable-dimension>/<policy-name>", d.Id())     
    }                                                                                                                                             
                                                                                                                                                  
    serviceNamespace := idParts[0]                                                                                                                
    resourceId := idParts[1]                                                                                                                      
    scalableDimension := idParts[2]                                                                                                               
    policyName := idParts[3]                                                                                                                      
                                                                                                                                                  
    d.Set("service_namespace", serviceNamespace)                                                                                                  
    d.Set("resource_id", resourceId)                                                                                                              
    d.Set("scalable_dimension", scalableDimension)                                                                                                
    d.Set("name", policyName)                                                                                                                     
    d.SetId(policyName)                                                                                                                                                                                                                                                                             
    return []*schema.ResourceData{d}, nil                                                                                                         
  }


if len(idParts) < 4 {
return nil, fmt.Errorf("unexpected format (%q), expected <service-namespace>/<resource-id>/<scalable-dimension>/<policy-name>", d.Id())
}

serviceNamespace := idParts[0]
resourceId := strings.Join(idParts[1:len(idParts)-2], "/")
scalableDimension := idParts[len(idParts)-2]
policyName := idParts[len(idParts)-1]
serviceNamespace, resourceId, scalableDimension, policyName = validateAppautoscalingPolicyImportInput(idParts)

if serviceNamespace == "" || resourceId == "" || scalableDimension == "" || policyName == "" {
return nil, fmt.Errorf("unexpected format (%q), expected <service-namespace>/<resource-id>/<scalable-dimension>/<policy-name>", d.Id())
Expand All @@ -430,6 +428,25 @@ func resourceAwsAppautoscalingPolicyImport(d *schema.ResourceData, meta interfac
return []*schema.ResourceData{d}, nil
}

func validateAppautoscalingPolicyImportInput(idParts []string) (string, string, string, string) {
var serviceNamespace, resourceId, scalableDimension, policyName string

switch idParts[0] {
nywilken marked this conversation as resolved.
Show resolved Hide resolved
case "ecs", "rds":
serviceNamespace = idParts[0]
resourceId = strings.Join(idParts[1:len(idParts)-2], "/")
scalableDimension = idParts[len(idParts)-2]
policyName = idParts[len(idParts)-1]
case "dynamodb":
serviceNamespace = idParts[len(idParts)-6]
jdecarli marked this conversation as resolved.
Show resolved Hide resolved
resourceId = strings.Join(idParts[1:3], "/")
scalableDimension = idParts[len(idParts)-3]
policyName = strings.Join(idParts[4:], "/")
}

return serviceNamespace, resourceId, scalableDimension, policyName
}

// Takes the result of flatmap.Expand for an array of step adjustments and
// returns a []*applicationautoscaling.StepAdjustment.
func expandAppautoscalingStepAdjustments(configured []interface{}) ([]*applicationautoscaling.StepAdjustment, error) {
Expand Down
39 changes: 39 additions & 0 deletions aws/resource_aws_appautoscaling_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package aws

import (
"fmt"
"strings"
"testing"

"github.com/aws/aws-sdk-go/aws"
Expand Down Expand Up @@ -310,6 +311,44 @@ func TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew(t *testing.T) {
})
}

func TestValidateAppautoscalingPolicyImportInput(t *testing.T) {
jdecarli marked this conversation as resolved.
Show resolved Hide resolved
testCases := []struct {
input string
expectedServiceNamespace string
expectedResourceId string
expectedScalableDimension string
expectedPolicyName string
}{
{
"rds/cluster:id/rds:cluster:ReadReplicaCount/cpu-auto-scaling",
"rds", "cluster:id", "rds:cluster:ReadReplicaCount", "cpu-auto-scaling"},
{
"ecs/service/clusterName/serviceName/ecs:service:DesiredCount/scale-down",
"ecs", "service/clusterName/serviceName", "ecs:service:DesiredCount", "scale-down"},
{
"dynamodb/table/tableName/dynamodb:table:ReadCapacityUnits/DynamoDBReadCapacityUtilization:table/tableName",
"dynamodb", "table/tableName", "dynamodb:table:ReadCapacityUnits", "DynamoDBReadCapacityUtilization:table/tableName"},
}

for _, test := range testCases {
idParts := strings.Split(test.input, "/")
serviceNamespace, resourceId, scalableDimension, policyName := validateAppautoscalingPolicyImportInput(idParts)

if serviceNamespace != test.expectedServiceNamespace {
t.Errorf("serviceNamespace interpolation error -> %s != %s", test.expectedServiceNamespace, serviceNamespace)
}
if resourceId != test.expectedResourceId {
t.Errorf("resourceId interpolation error -> %s != %s", test.expectedResourceId, resourceId)
}
if scalableDimension != test.expectedScalableDimension {
t.Errorf("scalableDimension interpolation error -> %s != %s", test.expectedScalableDimension, scalableDimension)
}
if policyName != test.expectedPolicyName {
t.Errorf("policyName interpolation error -> %s != %s", test.expectedPolicyName, policyName)
}
}
}

jdecarli marked this conversation as resolved.
Show resolved Hide resolved
func testAccCheckAWSAppautoscalingPolicyExists(n string, policy *applicationautoscaling.ScalingPolicy) resource.TestCheckFunc {
return func(s *terraform.State) error {
rs, ok := s.RootModule().Resources[n]
Expand Down