Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Amazon Managed Blockchain service client #8512

Merged
merged 1 commit into from May 6, 2019
Merged

Add Amazon Managed Blockchain service client #8512

merged 1 commit into from May 6, 2019

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Add service client for Amazon Managed Blockchain following the Contributing instructions.

Replaces #8501 which got into a git rebase mess.

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels May 3, 2019
@bflad bflad added this to the v2.10.0 milestone May 6, 2019
bflad
bflad approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ewbankkit 🚀

--- PASS: TestAccAWSProvider_Endpoints_Deprecated (1.96s)
--- PASS: TestAccAWSProvider_Endpoints (2.03s)

@bflad bflad merged commit 9aebcd6 into hashicorp:master May 6, 2019
@bflad bflad mentioned this pull request May 7, 2019
Merged
@ewbankkit ewbankkit deleted the add-managed-blockchain-service-client branch May 7, 2019 11:40
@ewbankkit ewbankkit mentioned this pull request Jun 4, 2019
Open
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ewbankkit @bflad