Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOL node engine 6.10 of lambda function #9341

Merged
merged 5 commits into from Jul 16, 2019
Merged

EOL node engine 6.10 of lambda function #9341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2afa58e
Update compatible node runtime
chaspy Jul 15, 2019
3db566b
Remove duplicate versions
chaspy Jul 15, 2019
7e6d7db
Revert wront fixing
chaspy Jul 15, 2019
ccfd957
Use newer runtime for TestAccAWSLambdaFunction_updateRuntime
chaspy Jul 16, 2019
95128f1
Add second runtime for TestAccAWSLambdaLayerVersion_compatibleRuntimes
chaspy Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions aws/resource_aws_lambda_function_test.go
View file
Open in desktop
Expand Up @@ -279,7 +279,7 @@ func TestAccAWSLambdaFunction_updateRuntime(t *testing.T) {
Config: testAccAWSLambdaConfigBasicUpdateRuntime(funcName, policyName, roleName, sgName),
Check: resource.ComposeTestCheckFunc(
testAccCheckAwsLambdaFunctionExists("aws_lambda_function.lambda_function_test", funcName, &conf),
resource.TestCheckResourceAttr("aws_lambda_function.lambda_function_test", "runtime", "nodejs6.10"),
resource.TestCheckResourceAttr("aws_lambda_function.lambda_function_test", "runtime", "nodejs10.x"),
),
},
},
Expand Down Expand Up @@ -1724,7 +1724,7 @@ resource "aws_lambda_function" "lambda_function_test" {
function_name = "%s"
role = "${aws_iam_role.iam_for_lambda.arn}"
handler = "exports.example"
runtime = "nodejs6.10"
runtime = "nodejs10.x"
}
`, funcName)
}
Expand Down
2 changes: 1 addition & 1 deletion aws/resource_aws_lambda_layer_version_test.go
View file
Open in desktop
Expand Up @@ -345,7 +345,7 @@ resource "aws_lambda_layer_version" "lambda_layer_test" {
filename = "test-fixtures/lambdatest.zip"
layer_name = "%s"

compatible_runtimes = ["nodejs8.10", "nodejs6.10"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TestAccAWSLambdaLayerVersion_compatibleRuntimes test that references this test configuration is currently expecting two values for the compatible_runtimes argument:

https://github.com/terraform-providers/terraform-provider-aws/blob/feacc804717a491202318f1ab217f5c76fa049e1/aws/resource_aws_lambda_layer_version_test.go#L168

Can you please add back a second runtime, e.g. nodejs10.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed: 95128f1

compatible_runtimes = ["nodejs8.10", "nodejs10.x"]
}
`, layerName)
}
Expand Down
2 changes: 1 addition & 1 deletion aws/resource_aws_pinpoint_app_test.go
View file
Open in desktop
Expand Up @@ -193,7 +193,7 @@ resource "aws_lambda_function" "test" {
function_name = "%s"
role = "${aws_iam_role.iam_for_lambda.arn}"
handler = "lambdapinpoint.handler"
runtime = "nodejs6.10"
runtime = "nodejs8.10"
publish = true
}

Expand Down
4 changes: 2 additions & 2 deletions website/docs/guides/serverless-with-aws-lambda-and-api-gateway.html.md
View file
Open in desktop
Expand Up @@ -151,7 +151,7 @@ resource "aws_lambda_function" "example" {
# is the name of the property under which the handler function was
# exported in that file.
handler = "main.handler"
runtime = "nodejs6.10"
runtime = "nodejs8.10"

role = "${aws_iam_role.lambda_exec.arn}"
}
Expand Down Expand Up @@ -227,7 +227,7 @@ aws_lambda_function.example: Creating...
publish: "" => "false"
qualified_arn: "" => "<computed>"
role: "" => "arn:aws:iam::123456:role/serverless_example_lambda"
runtime: "" => "nodejs6.10"
runtime: "" => "nodejs8.10"
s3_bucket: "" => "terraform-serverless-example"
s3_key: "" => "v1.0.0/example.zip"
source_code_hash: "" => "<computed>"
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/lambda_layer_version.html.markdown
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ resource "aws_lambda_layer_version" "lambda_layer" {
filename = "lambda_layer_payload.zip"
layer_name = "lambda_layer_name"

compatible_runtimes = ["nodejs8.10", "nodejs6.10"]
compatible_runtimes = ["nodejs8.10"]
}
```

Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/lambda_permission.html.markdown
View file
Open in desktop
Expand Up @@ -35,7 +35,7 @@ resource "aws_lambda_function" "test_lambda" {
function_name = "lambda_function_name"
role = "${aws_iam_role.iam_for_lambda.arn}"
handler = "exports.handler"
runtime = "nodejs6.10"
runtime = "nodejs8.10"
}

resource "aws_iam_role" "iam_for_lambda" {
Expand Down