azuread_application: avoid update after create #367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a set of small bugs which can occur by updating immediately after creating an application, mostly around the reliance on
d.GetChange()
, which is always true in this scenario.This PR refactors the update logic for the
app_role
andoauth2_permissions
properties into a helper function, and stops returningapplicationResourceUpdate()
at the end ofapplicationResourceCreate()
. Additionally fixes up the setting ofprevent_duplicate_names
on read to avoid unwanted diffs, and adds regression test coverage for that attribute.Sets
ConfigMode: schema.SchemaConfigModeAttr
on theapp_role
attribute to enable specifying an empty list in order to remove existing app roles. As with the other optional+computed attributes, this only works on update and if a config change is detected. Test also amended for this case.Resolves #364