Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert support for setting user_type to Guest #413

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

manicminer
Copy link
Member

@manicminer manicminer commented Mar 8, 2021

  • Adding users in this way bypasses the invitations API and creates broken accounts
  • No invitation email is sent, which is sort of expected but not great UX
  • The guest user can browse to the inviting tenant in the Portal, but cannot see it, or any linked subscriptions, in their global filter list
  • AAD roles assigned to such a user do not work
  • RBAC roles assigned to such a user do not work
  • Subscriptions do not work

We will reserve this functionality for MS Graph when we have access to the invitations API which processes guest accounts correctly.

Example:

Screenshot 2021-03-08 at 16 22 20

Reverts: #401

- Adding users in this way bypasses the invitations API and creates broken accounts
- No invitation email is sent, which is sort of expected but not great UX
- The guest user can browse to the inviting tenant in the Portal, but
  cannot see it, or any linked subscriptions, in their global filter list
- AAD roles assigned to such a user do not work
- RBAC roles assigned to such a user do not work
- Subscriptions do not work

We will reserve this functionality for MS Graph when we have access to
the invitations API which processes guest accounts correctly.
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manicminer - LGTM 👍

@manicminer manicminer merged commit b49d26c into main Mar 9, 2021
@manicminer manicminer deleted the r/revert-guest-user-support branch March 9, 2021 09:52
@ghost
Copy link

ghost commented Apr 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2021
@ghost ghost unlocked this conversation May 20, 2021
@ghost
Copy link

ghost commented May 20, 2021

This has been released in version 1.5.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 1.5.0"
}
# ... other configuration ...

@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants