Support URNs properly

[buffer51]

Fixes #425 by refactoring the URL validation to support both URLs & URNs.

I looked for Go packages that do URN validation, and found voicera/gooseberry urn#TryParseString and leodido/go-urn#Parse. Neither seemed worth adding as a dependency, so I used the simple validation logic from the former.

[buffer51]

I mistakenly had assumed URNs have 3 parts, but it's 3 or more parts. If we wanted to be stricter we could use a URN regex to make sure it's totally valid per the RFC (Google suggests a few), but we can't actually validate the parts (we'd need a library of known URN namespaces, which feels overkill).

Let me know what you think is more appropriate.

[manicminer]

@buffer51 Thanks for updating. A simple string split is perfectly fine, we don't want to be overly strict and I don't think it's necessary to wield a regex 🙂

[buffer51]

Brilliant @manicminer 😄 If I may, what is the release cadence for this project?

[manicminer]

That's difficult to characterize as we're working through the Microsoft Graph transition at the moment, but there is hopefully a release forthcoming in the next week or so.

[manicminer]

Thanks again @buffer51 and @MarkDordoy, this LGTM 👍

[ghost]

This has been released in version 1.5.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 1.5.0"
}
# ... other configuration ...

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.