Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/monitor_diagnostic_setting: handling a difference in casing the EHNamespace Authorization Rule #10104

Merged
merged 7 commits into from Jan 12, 2021
Merged

r/monitor_diagnostic_setting: handling a difference in casing the EHNamespace Authorization Rule #10104

merged 7 commits into from Jan 12, 2021

Conversation

andrey-dubnik
Copy link
Contributor

Handle Azure read response with AuthorizationRules (legacy) and authorizationRules

#10097

@ghost ghost added the size/XS label Jan 8, 2021
@tombuildsstuff tombuildsstuff changed the title handle legacy metadata r/monitor_diagnostic_setting: handling a difference in casing the EHNamespace Authorization Rule Jan 11, 2021
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @andrey-dubnik

Thanks for this PR - taking a look through whilst this does solve the issue by manipulating the ID, we should be able to use a segment insensitive parser here during rewriting by generating that instead - as such if we can update this to use that then this otherwise LGTM 👍

Thanks!

andrey-dubnik and others added 2 commits January 11, 2021 10:20
…esource.go

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@ghost ghost added size/L and removed size/XS labels Jan 11, 2021
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @andrey-dubnik 👍

@andrey-dubnik
Copy link
Contributor Author

@tombuildsstuff I've also changed a code gen as otherwise generated code was failing on lint during the CI tests. All passes now :)

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Member

Tests look good 👍

@ghost
Copy link

ghost commented Jan 14, 2021

This has been released in version 2.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.43.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants