Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/use parser for user assigned identity #10105

Conversation

sharebear
Copy link
Contributor

@sharebear sharebear commented Jan 8, 2021

First attempt at quickly adding parsing of user assigned identities when reading function apps, app service and "new" virtual machine resources

This fixes my immediate problem with differences in case causing changes in the plan for function_apps that were created before the new id parser was applied to user_assigned_identity.

If there are no objections I would be happy to add the necessary changes to also support the other resource types mentioned in #10029, #10098 and #10099

I think the total list of resources that should be touched are;

  • azurerm_app_service
  • azurerm_app_service_slot
  • azurerm_function_app
  • azurerm_function_app_slot
  • azurerm_windows_virtual_machine
  • azurerm_linux_virtual_machine
  • azurerm_api_management
  • azurerm_blueprint_assignment
  • azurerm_virtual_machine_scale_set
  • azurerm_virtual_machine
  • azurerm_container_group
  • azurerm_kubernetes_cluster
  • azurerm_kusto_cluster
  • azurerm_application_gateway (change handled in r/application_gateway: ensuring the casing on identity_ids within the identity block #10031)

This will fix case sensitivity issues when comparing state with resources created before the parser was added to the user_assigned_identity resource
@ghost ghost added the size/S label Jan 8, 2021
@ghost ghost added size/M and removed size/S labels Jan 8, 2021
@sharebear
Copy link
Contributor Author

Hi @tombuildsstuff, I see you approved #10031 should I take that as a sign that I should continue distributing the same fix to the other resources mentioned in the description here?

@tombuildsstuff
Copy link
Member

@sharebear

I see you approved #10031 should I take that as a sign that I should continue distributing the same fix to the other resources mentioned in the description here?

Sure that'd be great if you don't mind 👍

@ghost ghost added size/XL and removed size/M labels Jan 11, 2021
@ghost ghost added size/L and removed size/XL labels Jan 11, 2021
@sharebear
Copy link
Contributor Author

@tombuildsstuff Is this looking ok now?

@tombuildsstuff tombuildsstuff self-assigned this Jan 12, 2021
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghost
Copy link

ghost commented Jan 14, 2021

This has been released in version 2.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.43.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 12, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants